chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc - Issue 541753004: Split web_view_internal_api and move part of it to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

Issue 541753004: Split web_view_internal_api and move part of it to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/_api_features.json ('K') | « chrome/common/extensions/api/web_view_internal.json ('k') | chrome/renderer/resources/extensions/chrome_web_view_internal_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

diff --git a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

index 3b7bbbd2b48dc75e6081029e4405db6d14153854..5d095c9eb28fdf6797d27ffc66dd3efee3abe951 100644

--- a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

+++ b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

@@ -233,8 +233,8 @@ void ChromeExtensionsDispatcherDelegate::PopulateSourceMap(

source_map->RegisterSource("extensionOptionsEvents",

IDR_EXTENSION_OPTIONS_EVENTS_JS);

source_map->RegisterSource("tagWatcher", IDR_TAG_WATCHER_JS);

- source_map->RegisterSource("webViewInternal",

- IDR_WEB_VIEW_INTERNAL_CUSTOM_BINDINGS_JS);

+ source_map->RegisterSource("chromeWebViewInternal",

+ IDR_CHROME_WEB_VIEW_INTERNAL_CUSTOM_BINDINGS_JS);

// Note: webView not webview so that this doesn't interfere with the

// chrome.webview API bindings.

source_map->RegisterSource("webView", IDR_WEB_VIEW_JS);