chrome/renderer/resources/extensions/chrome_web_view_internal_custom_bindings.js - Issue 541753004: Split web_view_internal_api and move part of it to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/chrome_web_view_internal_custom_bindings.js

Issue 541753004: Split web_view_internal_api and move part of it to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/_api_features.json ('K') | « chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc ('k') | chrome/renderer/resources/extensions/web_view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/chrome_web_view_internal_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/web_view_internal_custom_bindings.js b/chrome/renderer/resources/extensions/chrome_web_view_internal_custom_bindings.js

similarity index 97%

rename from chrome/renderer/resources/extensions/web_view_internal_custom_bindings.js

rename to chrome/renderer/resources/extensions/chrome_web_view_internal_custom_bindings.js

index 6ab8d0d0794745c0105fe86ee2f5c5c52e9f8786..c55d644150c7a668bb9ac0be83f8ded39f5d771a 100644

--- a/chrome/renderer/resources/extensions/web_view_internal_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/chrome_web_view_internal_custom_bindings.js

@@ -11,7 +11,7 @@

// TODO(lazyboy): Share common code /w context_menus_custom_bindings.js.

var EventBindings = require('event_bindings');

-var binding = require('binding').Binding.create('webViewInternal');

+var binding = require('binding').Binding.create('chromeWebViewInternal');

var contextMenuNatives = requireNative('context_menus');

var sendRequest = require('sendRequest').sendRequest;

@@ -127,4 +127,4 @@ binding.registerCustomHook(function(bindingsAPI) {

});

-exports.WebView = binding.generate();

+exports.ChromeWebView = binding.generate();