Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: components/renderer_context_menu/render_view_context_menu_base.cc

Issue 541753003: Use stored render_frame_id_ instead of using GetRenderFrameHost(), as it may return NULL (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/renderer_context_menu/render_view_context_menu_base.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/renderer_context_menu/render_view_context_menu_base.cc
diff --git a/components/renderer_context_menu/render_view_context_menu_base.cc b/components/renderer_context_menu/render_view_context_menu_base.cc
index aa47c91f356dab44793e117c5be581f6a9fbe5e3..5cfa2d83f44467e2723ace2027b17fba217d86e4 100644
--- a/components/renderer_context_menu/render_view_context_menu_base.cc
+++ b/components/renderer_context_menu/render_view_context_menu_base.cc
@@ -161,9 +161,9 @@ RenderViewContextMenuBase::RenderViewContextMenuBase(
source_web_contents_(WebContents::FromRenderFrameHost(render_frame_host)),
browser_context_(source_web_contents_->GetBrowserContext()),
menu_model_(this),
+ render_frame_id_(render_frame_host->GetRoutingID()),
command_executed_(false),
- render_process_id_(render_frame_host->GetProcess()->GetID()),
- render_frame_id_(render_frame_host->GetRoutingID()) {
+ render_process_id_(render_frame_host->GetProcess()->GetID()) {
}
RenderViewContextMenuBase::~RenderViewContextMenuBase() {
« no previous file with comments | « components/renderer_context_menu/render_view_context_menu_base.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698