components/renderer_context_menu/render_view_context_menu_base.h - Issue 541753003: Use stored render_frame_id_ instead of using GetRenderFrameHost(), as it may return NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/renderer_context_menu/render_view_context_menu_base.h

Issue 541753003: Use stored render_frame_id_ instead of using GetRenderFrameHost(), as it may return NULL (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | components/renderer_context_menu/render_view_context_menu_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/renderer_context_menu/render_view_context_menu_base.h

diff --git a/components/renderer_context_menu/render_view_context_menu_base.h b/components/renderer_context_menu/render_view_context_menu_base.h

index 5452f1e608e9cc56700f208c7032a6f7ec3777c3..db6c175c016a8c5fff4d97ebd5c967758dbb24a3 100644

--- a/components/renderer_context_menu/render_view_context_menu_base.h

+++ b/components/renderer_context_menu/render_view_context_menu_base.h

@@ -166,6 +166,9 @@ class RenderViewContextMenuBase : public ui::SimpleMenuModel::Delegate,

ui::SimpleMenuModel menu_model_;

+ // Renderer's frame id.

+ int render_frame_id_;

// Our observers.

mutable ObserverList<RenderViewContextMenuObserver> observers_;

@@ -180,7 +183,6 @@ class RenderViewContextMenuBase : public ui::SimpleMenuModel::Delegate,

// The RenderFrameHost's IDs.

int render_process_id_;

- int render_frame_id_;

scoped_ptr<ToolkitDelegate> toolkit_delegate_;