Issue 541753003: Use stored render_frame_id_ instead of using GetRenderFrameHost(), as it may return NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 541753003: Use stored render_frame_id_ instead of using GetRenderFrameHost(), as it may return NULL (Closed)

Created:
6 years, 3 months ago by oshima

Modified:
6 years, 3 months ago

Reviewers:
lazyboy

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src@master

Project:
chromium

Visibility:
Public.

Use stored render_frame_id_ instead of using GetRenderFrameHost(), as it may return NULL BUG=402028 R=lazyboy@chromium.org Committed: https://crrev.com/f08f0fe2e8a5e38a2fa63e0400e6499e08a64a9c Cr-Commit-Position: refs/heads/master@{#293398}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -4 lines)			Patch
M	chrome/browser/renderer_context_menu/render_view_context_menu.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	components/renderer_context_menu/render_view_context_menu_base.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	components/renderer_context_menu/render_view_context_menu_base.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/541753003/20001

6 years, 3 months ago (2014-09-04 20:27:31 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:20001) as 82a89f22568ef642a57e2c7fcc7f7c8e96a5ded3

6 years, 3 months ago (2014-09-05 01:57:10 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:35:30 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f08f0fe2e8a5e38a2fa63e0400e6499e08a64a9c
Cr-Commit-Position: refs/heads/master@{#293398}