Source/core/editing/VisibleSelection.h - Issue 541633004: Avoid temporary range allocation in FrameSelection::respondToNodeModification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleSelection.h

Issue 541633004: Avoid temporary range allocation in FrameSelection::respondToNodeModification. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/VisibleSelection.h

diff --git a/Source/core/editing/VisibleSelection.h b/Source/core/editing/VisibleSelection.h

index 0256f17bd0ed4075075c7085dc3cc1cea194a075..d1990dae6ac884f666aba34367f9579f17bffb67 100644

--- a/Source/core/editing/VisibleSelection.h

+++ b/Source/core/editing/VisibleSelection.h

@@ -96,6 +96,8 @@ public:

// We don't yet support multi-range selections, so we only ever have one range to return.

PassRefPtrWillBeRawPtr<Range> firstRange() const;

+ bool intersectsNode(Node*) const;

// FIXME: Most callers probably don't want this function, but are using it

// for historical reasons. toNormalizedRange contracts the range around

// text, and moves the caret upstream before returning the range.

« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »