Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: Source/core/editing/VisibleSelection.h

Issue 541633004: Avoid temporary range allocation in FrameSelection::respondToNodeModification. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address review comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 bool isDirectional() const { return m_isDirectional; } 89 bool isDirectional() const { return m_isDirectional; }
90 void setIsDirectional(bool isDirectional) { m_isDirectional = isDirectional; } 90 void setIsDirectional(bool isDirectional) { m_isDirectional = isDirectional; }
91 91
92 void appendTrailingWhitespace(); 92 void appendTrailingWhitespace();
93 93
94 bool expandUsingGranularity(TextGranularity granularity); 94 bool expandUsingGranularity(TextGranularity granularity);
95 95
96 // We don't yet support multi-range selections, so we only ever have one ran ge to return. 96 // We don't yet support multi-range selections, so we only ever have one ran ge to return.
97 PassRefPtrWillBeRawPtr<Range> firstRange() const; 97 PassRefPtrWillBeRawPtr<Range> firstRange() const;
98 98
99 bool intersectsNode(Node*) const;
100
99 // FIXME: Most callers probably don't want this function, but are using it 101 // FIXME: Most callers probably don't want this function, but are using it
100 // for historical reasons. toNormalizedRange contracts the range around 102 // for historical reasons. toNormalizedRange contracts the range around
101 // text, and moves the caret upstream before returning the range. 103 // text, and moves the caret upstream before returning the range.
102 PassRefPtrWillBeRawPtr<Range> toNormalizedRange() const; 104 PassRefPtrWillBeRawPtr<Range> toNormalizedRange() const;
103 105
104 Element* rootEditableElement() const; 106 Element* rootEditableElement() const;
105 bool isContentEditable() const; 107 bool isContentEditable() const;
106 bool hasEditableStyle() const; 108 bool hasEditableStyle() const;
107 bool isContentRichlyEditable() const; 109 bool isContentRichlyEditable() const;
108 // Returns a shadow tree node for legacy shadow trees, a child of the 110 // Returns a shadow tree node for legacy shadow trees, a child of the
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 187
186 } // namespace blink 188 } // namespace blink
187 189
188 #ifndef NDEBUG 190 #ifndef NDEBUG
189 // Outside the WebCore namespace for ease of invocation from gdb. 191 // Outside the WebCore namespace for ease of invocation from gdb.
190 void showTree(const blink::VisibleSelection&); 192 void showTree(const blink::VisibleSelection&);
191 void showTree(const blink::VisibleSelection*); 193 void showTree(const blink::VisibleSelection*);
192 #endif 194 #endif
193 195
194 #endif // VisibleSelection_h 196 #endif // VisibleSelection_h
OLDNEW
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698