Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 541593003: Small improvement on handling of (Windows) executables in Files.app. (Closed)

Created:
6 years, 3 months ago by kinaba
Modified:
6 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Small improvement on handling of (Windows) executables in Files.app. - Treat *.msi files (typical extension for installer) as PC exe. - Link to webstore top page. Finding apps associated to .exe or .msi doesn't make much sense. TEST=Double click a file named setup.msi in Files.app. BUG=none R=hirono@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e625fe9979d4da7ea8939ffe1fea1ce1db958e9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/file_tasks.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
kinaba
ptal
6 years, 3 months ago (2014-09-04 09:12:16 UTC) #2
hirono
lgtm. Thank you for fixing it.
6 years, 3 months ago (2014-09-04 09:22:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/541593003/1
6 years, 3 months ago (2014-09-04 09:36:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/53528)
6 years, 3 months ago (2014-09-04 16:07:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/541593003/1
6 years, 3 months ago (2014-09-04 16:21:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/53592) mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/43683) mac_gpu_triggered_tests ...
6 years, 3 months ago (2014-09-04 17:29:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/541593003/1
6 years, 3 months ago (2014-09-05 02:58:35 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/47842)
6 years, 3 months ago (2014-09-05 03:52:14 UTC) #15
kinaba
Committed patchset #1 (id:1) manually as e625fe9 (presubmit successful).
6 years, 3 months ago (2014-09-05 04:06:02 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:32 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e625fe9979d4da7ea8939ffe1fea1ce1db958e9c
Cr-Commit-Position: refs/heads/master@{#293430}

Powered by Google App Engine
This is Rietveld 408576698