ui/file_manager/file_manager/foreground/js/file_tasks.js - Issue 541593003: Small improvement on handling of (Windows) executables in Files.app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/file_tasks.js

Issue 541593003: Small improvement on handling of (Windows) executables in Files.app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/file_manager/file_manager/foreground/js/file_tasks.js

diff --git a/ui/file_manager/file_manager/foreground/js/file_tasks.js b/ui/file_manager/file_manager/foreground/js/file_tasks.js

index e26c6963381f4f9f33a4ebebb88a1db4f5a2ed3f..a4cf023df4e9597a3007569c3a9d4d38cf556fd4 100644

--- a/ui/file_manager/file_manager/foreground/js/file_tasks.js

+++ b/ui/file_manager/file_manager/foreground/js/file_tasks.js

@@ -63,7 +63,7 @@ FileTasks.VIDEO_PLAYER_ID = 'jcgeabjmjgoblfofpppfkcoakmfobdko';

* @return {string} URL

FileTasks.createWebStoreLink = function(extension, mimeType) {

- if (!extension)

+ if (!extension || FileTasks.EXECUTABLE_EXTENSIONS.indexOf(extension) !== -1)

return FileTasks.CHROME_WEB_STORE_URL;

if (extension[0] === '.')

@@ -327,6 +327,7 @@ FileTasks.prototype.executeDefaultInternal_ = function(entries, opt_callback) {

var titleMessageId;

switch (extension) {

case '.exe':

+ case '.msi':

textMessageId = 'NO_ACTION_FOR_EXECUTABLE';

break;

case '.dmg':

« no previous file with comments | « no previous file | no next file » | no next file with comments »