Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 541403002: Rename ChromeVox tests and utilities for consistency. (Closed)

Created:
6 years, 3 months ago by Peter Lundblad
Modified:
6 years, 3 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Rename ChromeVox tests and utilities for consistency. Unit tests are now named *.unitjs instead of just *.js. This is consistent with the e2e tests having a separate extension. This avoids the files being read by the deps graph tools and avoids regenerating/recompiling all tests when changing just one (because the edpendency of the test_deps.js file on each test is now removed). This also renames a test base class to use test_base.js to be consistent. BUG=371692 Committed: https://crrev.com/21ed27a903e44827b08aa718894768bd30d4b4f7 Cr-Commit-Position: refs/heads/master@{#293711}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Clarify comment in .gypi file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10820 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi View 1 3 chunks +18 lines, -17 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/aria_util_test.js View 1 chunk +0 lines, -142 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/aria_util_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/braille_text_handler_test.js View 1 chunk +0 lines, -70 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/braille_text_handler_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/braille_util_test.js View 1 chunk +0 lines, -401 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/command_store_test.js View 1 chunk +0 lines, -73 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/command_store_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/content_editable_extractor_test.js View 1 chunk +0 lines, -310 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/content_editable_extractor_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/cursor_selection_test.js View 1 chunk +0 lines, -97 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/cursor_selection_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/dom_util_test.js View 1 chunk +0 lines, -1578 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/dom_util_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/editable_text_area_shadow_test.js View 1 chunk +0 lines, -65 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/editable_text_area_shadow_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/editable_text_test.js View 1 chunk +0 lines, -670 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/find_util_test.js View 1 chunk +0 lines, -51 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/find_util_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.js View 1 chunk +0 lines, -445 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/math_semantic_tree_test.js View 1 chunk +0 lines, -6188 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/math_semantic_tree_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/page_selection_test.js View 1 chunk +0 lines, -143 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/page_selection_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/selection_util_test.js View 1 chunk +0 lines, -31 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/selection_util_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common/spannable_test.js View 1 chunk +0 lines, -481 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/common/spannable_test.unitjs View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test.js View 1 chunk +0 lines, -73 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.extjs View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Peter Lundblad
6 years, 3 months ago (2014-09-05 13:39:07 UTC) #2
David Tseng
lgtm https://codereview.chromium.org/541403002/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi File chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi (left): https://codereview.chromium.org/541403002/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi#oldcode42 chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi:42: # A JavaScript test that runs in an ...
6 years, 3 months ago (2014-09-05 16:43:56 UTC) #3
Peter Lundblad
dtseng@chromium.org writes: > lgtm > > > > > https://codereview.chromium.org/541403002/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi > File chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi > (left): ...
6 years, 3 months ago (2014-09-08 10:27:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/541403002/20001
6 years, 3 months ago (2014-09-08 10:31:15 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-08 12:31:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/541403002/20001
6 years, 3 months ago (2014-09-08 12:41:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 61854931ddd54987143774d32b5ea1bf88831b4a
6 years, 3 months ago (2014-09-08 12:56:17 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:51 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21ed27a903e44827b08aa718894768bd30d4b4f7
Cr-Commit-Position: refs/heads/master@{#293711}

Powered by Google App Engine
This is Rietveld 408576698