Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi

Issue 541403002: Rename ChromeVox tests and utilities for consistency. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Clarify comment in .gypi file. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/common/aria_util_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi b/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi
index 3806b4f72c81313ce2b8250fe0a9e50b65ce95f6..b8c17fd4753d73d8702c9d1c85b5c90b79e944ae 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi
@@ -40,9 +40,10 @@
'rules': [
{
# A JavaScript test that runs in an environment similar to a webui
- # browser test.
+ # browser test. This is meant for unit tests that test individual
+ # components without depending on the ChromeVox extension.
'rule_name': 'js2webui',
- 'extension': 'js',
+ 'extension': 'unitjs',
'msvs_external_rule': 1,
'inputs': [
'<(gypv8sh)',
@@ -68,7 +69,7 @@
'<(js2gtest)',
'webui',
'<(RULE_INPUT_PATH)',
- 'chrome/browser/resources/chromeos/chromevox/<(RULE_INPUT_DIRNAME)/<(RULE_INPUT_ROOT).js',
+ 'chrome/browser/resources/chromeos/chromevox/<(RULE_INPUT_DIRNAME)/<(RULE_INPUT_ROOT).unitjs',
'<@(_outputs)',
],
},
@@ -122,20 +123,20 @@
'<(DEPTH)/chrome/browser/extensions/browsertest_util.cc',
'<(DEPTH)/chrome/browser/extensions/browsertest_util.h',
- 'common/aria_util_test.js',
- 'common/braille_text_handler_test.js',
- 'common/braille_util_test.js',
- 'common/command_store_test.js',
- 'common/cursor_selection_test.js',
- 'common/dom_util_test.js',
- 'common/editable_text_area_shadow_test.js',
- 'common/editable_text_test.js',
- 'common/find_util_test.js',
- 'common/key_sequence_test.js',
- 'common/math_semantic_tree_test.js',
- 'common/page_selection_test.js',
- 'common/selection_util_test.js',
- 'common/spannable_test.js',
+ 'common/aria_util_test.unitjs',
+ 'common/braille_text_handler_test.unitjs',
+ 'common/braille_util_test.unitjs',
+ 'common/command_store_test.unitjs',
+ 'common/cursor_selection_test.unitjs',
+ 'common/dom_util_test.unitjs',
+ 'common/editable_text_area_shadow_test.unitjs',
+ 'common/editable_text_test.unitjs',
+ 'common/find_util_test.unitjs',
+ 'common/key_sequence_test.unitjs',
+ 'common/math_semantic_tree_test.unitjs',
+ 'common/page_selection_test.unitjs',
+ 'common/selection_util_test.unitjs',
+ 'common/spannable_test.unitjs',
],
'conditions': [
['use_chromevox_next==1', {
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/common/aria_util_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698