Clean up code generator before implementing [ExposeV8GetterAndSetter]

Clean up code generator before implementing [ExposeV8GetterAndSetter]

This CL just renames variables to make the main change diff saner.

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161030

[haraken, 2013-10-31 06:47:11]

PTAL

[haraken, 2013-10-31 06:47:47]

https://codereview.chromium.org/54123003/diff/1/Source/bindings/scripts/code_...
File Source/bindings/scripts/code_generator_v8.pm (left):

https://codereview.chromium.org/54123003/diff/1/Source/bindings/scripts/code_...
Source/bindings/scripts/code_generator_v8.pm:4526: die "Wrong number of
callbacks generated for $interfaceName ($num_callbacks, should be
$total_functions)" if $num_callbacks != $total_functions;

This check is not helpful. So removed.

[Nils Barth (inactive), 2013-10-31 07:00:35]

LGTM, with one formatting fix.

https://codereview.chromium.org/54123003/diff/1/Source/bindings/scripts/code_...
File Source/bindings/scripts/code_generator_v8.pm (left):

https://codereview.chromium.org/54123003/diff/1/Source/bindings/scripts/code_...
Source/bindings/scripts/code_generator_v8.pm:4526: die "Wrong number of
callbacks generated for $interfaceName ($num_callbacks, should be
$total_functions)" if $num_callbacks != $total_functions;
On 2013/10/31 06:47:47, haraken wrote:
> This check is not helpful. So removed.

Agreed; this is just saying "code is confusing enough that it's not even clear
that we're looping over all functions"!

https://codereview.chromium.org/54123003/diff/1/Source/bindings/scripts/code_...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/54123003/diff/1/Source/bindings/scripts/code_...
Source/bindings/scripts/code_generator_v8.pm:4407: $code .=  $hasAttributes ?
"${v8ClassName}Attributes, WTF_ARRAY_LENGTH(${v8ClassName}Attributes)," : "0,
0,";
You want a trailing ' ' here to replace the newline.

[haraken, 2013-10-31 07:02:27]

https://codereview.chromium.org/54123003/diff/1/Source/bindings/scripts/code_...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/54123003/diff/1/Source/bindings/scripts/code_...
Source/bindings/scripts/code_generator_v8.pm:4407: $code .=  $hasAttributes ?
"${v8ClassName}Attributes, WTF_ARRAY_LENGTH(${v8ClassName}Attributes)," : "0,
0,";
On 2013/10/31 07:00:36, Nils Barth wrote:
> You want a trailing ' ' here to replace the newline.

Done.

[commit-bot: I haz the power, 2013-10-31 07:03:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/54123003/90001

[commit-bot: I haz the power, 2013-10-31 07:04:17]

Change committed as 161030