Descriptionfix for high resolution timer on windows.
The CLs here
https://codereview.chromium.org/489793003
and here
https://codereview.chromium.org/395913006
In isolation look correct but taken together cause a overflow or underflow
bug. Basically the message loop was calling Time::ActivateHighResolutionTimer(false)
all the time (or very often) so the g_high_res_timer_count was underflowing
or overflowing.
Now messageloop only calls ActivateHighResolutionTimer in a balanced way.
This can make the base_unittests fail as well with
--gtest_filter=MessageLoopTest.HighResolutionTimer
BUG=153139
TEST=included, see bug for manual testing.
Committed: https://crrev.com/3365a510b17169457292bdb6144cc8b95fb7ea34
Cr-Commit-Position: refs/heads/master@{#293434}
Patch Set 1 #
Total comments: 2
Patch Set 2 : nits fixes #
Messages
Total messages: 8 (2 generated)
|