content/renderer/media/media_stream_video_capture_source_unittest.cc - Issue 541163002: Clarify resolution change behaviors of video capture devices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_video_capture_source_unittest.cc

Issue 541163002: Clarify resolution change behaviors of video capture devices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixed build Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/video_capture_host.cc ('K') | « content/common/media/video_capture_messages.h ('k') | content/renderer/media/media_stream_video_capturer_source.cc » ('j') | media/video/capture/video_capture_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_video_capture_source_unittest.cc

diff --git a/content/renderer/media/media_stream_video_capture_source_unittest.cc b/content/renderer/media/media_stream_video_capture_source_unittest.cc

index 8492039a7bd6a6521965cc19a4f74cd5ed0c7ff1..5bc075d64582f9fa0544e0636fe2d314590cbd1f 100644

--- a/content/renderer/media/media_stream_video_capture_source_unittest.cc

+++ b/content/renderer/media/media_stream_video_capture_source_unittest.cc

@@ -96,7 +96,8 @@ TEST_F(MediaStreamVideoCapturerSourceTest, TabCaptureAllowResolutionChange) {

InitWithDeviceInfo(device_info);

EXPECT_CALL(mock_delegate(), StartCapture(

- testing::Field(&media::VideoCaptureParams::allow_resolution_change, true),

+ testing::Field(&media::VideoCaptureParams::resolution_change_policy,

+ media::RESOLUTION_POLICY_DYNAMIC_WITHIN_LIMIT),

testing::_,

testing::_)).Times(1);

blink::WebMediaStreamTrack track = StartSource();

@@ -111,7 +112,8 @@ TEST_F(MediaStreamVideoCapturerSourceTest,