Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/renderer_host/media/video_capture_host.cc

Issue 541163002: Clarify resolution change behaviors of video capture devices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/media/capture/desktop_capture_device.cc ('K') | « content/browser/media/capture/web_contents_video_capture_device_unittest.cc ('k') | content/common/media/video_capture_messages.h » ('j') | media/video/capture/video_capture_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/video_capture_host.cc
diff --git a/content/browser/renderer_host/media/video_capture_host.cc b/content/browser/renderer_host/media/video_capture_host.cc
index 604cb323be12741569cdd7cd8fa2541cac4bc02b..036f0cbdc5ca3cacd7000114ae9de6f2bb7523e2 100644
--- a/content/browser/renderer_host/media/video_capture_host.cc
+++ b/content/browser/renderer_host/media/video_capture_host.cc
@@ -220,7 +220,9 @@ void VideoCaptureHost::OnStartCapture(int device_id,
<< ", device_id=" << device_id
<< ", format=" << params.requested_format.frame_size.ToString()
mcasas 2014/09/08 09:09:53 Please use params.requested_format.ToString().
Alpha Left Google 2014/09/09 01:04:22 Done.
<< "@" << params.requested_format.frame_rate
- << " (" << (params.allow_resolution_change ? "variable" : "constant")
+ << " (" << (params.resolution_change_policy ==
+ media::RESOLUTION_POLICY_DYNAMIC_WITHIN_LIMIT ?
perkj_chrome 2014/09/07 14:07:09 indent 4 more.
Alpha Left Google 2014/09/09 01:04:22 Done.
+ "variable" : "constant")
<< ")";
VideoCaptureControllerID controller_id(device_id);
if (entries_.find(controller_id) != entries_.end()) {
« content/browser/media/capture/desktop_capture_device.cc ('K') | « content/browser/media/capture/web_contents_video_capture_device_unittest.cc ('k') | content/common/media/video_capture_messages.h » ('j') | media/video/capture/video_capture_types.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698