Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 540823002: Refactor common unit test code. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactor common unit test code. TEST=compiler-unittests BUG=v8:3489 LOG=n R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23673

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Fixes #

Patch Set 4 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -270 lines) Patch
D src/compiler/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-operator-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/compiler.gyp View 1 3 chunks +2 lines, -28 lines 0 comments Download
A + src/compiler/compiler-test-utils.h View 2 chunks +4 lines, -37 lines 0 comments Download
D src/compiler/compiler-unittests.h View 1 chunk +0 lines, -90 lines 0 comments Download
D src/compiler/compiler-unittests.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M src/compiler/graph-unittest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector-unittest.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/instruction-selector-unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/machine-operator-unittest.cc View 1 chunk +9 lines, -8 lines 0 comments Download
A src/test/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A src/test/run-all-unittests.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A + src/test/test.gyp View 1 2 chunks +24 lines, -5 lines 0 comments Download
A src/test/test-utils.h View 1 chunk +86 lines, -0 lines 0 comments Download
A src/test/test-utils.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M testing/gmock.gyp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 3 months ago (2014-09-04 08:12:42 UTC) #2
Sven Panne
lgtm
6 years, 3 months ago (2014-09-04 08:42:14 UTC) #3
Benedikt Meurer
6 years, 3 months ago (2014-09-04 08:44:24 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 23673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698