Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/compiler/compiler-test-utils.h

Issue 540823002: Refactor common unit test code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/compiler.gyp ('k') | src/compiler/compiler-unittests.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/compiler-test-utils.h
diff --git a/src/compiler/compiler-unittests.h b/src/compiler/compiler-test-utils.h
similarity index 63%
rename from src/compiler/compiler-unittests.h
rename to src/compiler/compiler-test-utils.h
index dd4234b9613027b863f9413f1d57318ae031c370..437abd68f69542686142672ad7c772159e78bd3f 100644
--- a/src/compiler/compiler-unittests.h
+++ b/src/compiler/compiler-test-utils.h
@@ -2,20 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef V8_COMPILER_UNITTESTS_COMPILER_UNITTESTS_H_
-#define V8_COMPILER_UNITTESTS_COMPILER_UNITTESTS_H_
+#ifndef V8_COMPILER_COMPILER_TEST_UTILS_H_
+#define V8_COMPILER_COMPILER_TEST_UTILS_H_
-#include "include/v8.h"
-#include "src/zone.h"
-#include "testing/gtest-support.h"
+#include "testing/gtest/include/gtest/gtest.h"
namespace v8 {
namespace internal {
-
-// Forward declarations.
-class Factory;
-
-
namespace compiler {
// The TARGET_TEST(Case, Name) macro works just like
@@ -57,34 +50,8 @@ namespace compiler {
#define TARGET_TYPED_TEST(Case, Name) TYPED_TEST(Case, DISABLED_##Name)
#endif
-
-class CompilerTest : public ::testing::Test {
- public:
- CompilerTest();
- virtual ~CompilerTest();
-
- Factory* factory() const;
- Isolate* isolate() const { return reinterpret_cast<Isolate*>(isolate_); }
- Zone* zone() { return &zone_; }
-
- static void SetUpTestCase();
- static void TearDownTestCase();
-
- private:
- static v8::Isolate* isolate_;
- v8::Isolate::Scope isolate_scope_;
- v8::HandleScope handle_scope_;
- v8::Context::Scope context_scope_;
- Zone zone_;
-};
-
-
-template <typename T>
-class CompilerTestWithParam : public CompilerTest,
- public ::testing::WithParamInterface<T> {};
-
} // namespace compiler
} // namespace internal
} // namespace v8
-#endif // V8_COMPILER_UNITTESTS_COMPILER_UNITTESTS_H_
+#endif // V8_COMPILER_COMPILER_TEST_UTILS_H_
« no previous file with comments | « src/compiler/compiler.gyp ('k') | src/compiler/compiler-unittests.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698