chromeos/test/data/network/shill_ethernet_with_ipconfig.json - Issue 540613002: Translate Saved/StaticIPConfig properties from ONC to Shill

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/test/data/network/shill_ethernet_with_ipconfig.json

Issue 540613002: Translate Saved/StaticIPConfig properties from ONC to Shill (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/onc/onc_translator_shill_to_onc.cc ('K') | « chromeos/network/onc/onc_translator_shill_to_onc.cc ('k') | chromeos/test/data/network/translation_of_shill_ethernet_with_ipconfig.onc » ('j') | chromeos/test/data/network/translation_of_shill_ethernet_with_ipconfig.onc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/test/data/network/shill_ethernet_with_ipconfig.json

diff --git a/chromeos/test/data/network/shill_ethernet_with_ipconfig.json b/chromeos/test/data/network/shill_ethernet_with_ipconfig.json

index 3eae24ef2eada98de9543a0bd1e7021e2f864ef6..f06a5beefbbe5b50f25b0be259042da063027a77 100644

--- a/chromeos/test/data/network/shill_ethernet_with_ipconfig.json

+++ b/chromeos/test/data/network/shill_ethernet_with_ipconfig.json

@@ -9,7 +9,8 @@

"1.1.1.2",

"1.1.1.3"

- "Prefixlen":24

+ "Prefixlen":24,

+ "WebProxyAutoDiscoveryUrl":"proxy.url"

{

"Address":"2001:0db8:85a3:0000:0000:8a2e:0370:7334",

@@ -19,5 +20,13 @@

"Prefixlen":12

}

+ "SavedIP.Address":"456.456.456.456",

pneubeck (no reviews) 2014/09/04 12:38:45 better use a valid ipaddress ;-)

stevenjb 2014/09/04 15:26:21 Done.

+ "SavedIP.Gateway":"1.1.1.4",

+ "SavedIP.NameServers":"1.1.1.5,1.1.1.6",

pneubeck (no reviews) 2014/09/04 12:38:45 i'll file a bug for this to be fixed in Shill

stevenjb 2014/09/04 15:26:21 If we are going to "fix" this (I assume you mean c

+ "SavedIP.Prefixlen":25,

+ "StaticIP.Address":"789.789.789.789",

pneubeck (no reviews) 2014/09/04 12:38:45 dito

stevenjb 2014/09/04 15:26:21 Done

+ "StaticIP.Gateway":"1.1.1.7",

+ "StaticIP.NameServers":"1.1.1.8",

+ "StaticIP.Prefixlen":26,

"Type":"ethernet"

}