chromeos/test/data/network/shill_ethernet_with_ipconfig.json - Issue 540613002: Translate Saved/StaticIPConfig properties from ONC to Shill

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/test/data/network/shill_ethernet_with_ipconfig.json

Issue 540613002: Translate Saved/StaticIPConfig properties from ONC to Shill (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chromeos/network/onc/onc_translator_shill_to_onc.cc ('K') | « chromeos/network/onc/onc_translator_shill_to_onc.cc ('k') | chromeos/test/data/network/translation_of_shill_ethernet_with_ipconfig.onc » ('j') | chromeos/test/data/network/translation_of_shill_ethernet_with_ipconfig.onc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "GUID":"guid",	2 "GUID":"guid",

3 "IPConfigs":[	3 "IPConfigs":[

4 {	4 {

5 "Address":"123.123.123.123",	5 "Address":"123.123.123.123",

6 "Gateway":"1.1.1.1",	6 "Gateway":"1.1.1.1",

7 "Method":"ipv4",	7 "Method":"ipv4",

8 "NameServers":[	8 "NameServers":[

9 "1.1.1.2",	9 "1.1.1.2",

10 "1.1.1.3"	10 "1.1.1.3"

11 ],	11 ],

12 "Prefixlen":24	12 "Prefixlen":24,

	13 "WebProxyAutoDiscoveryUrl":"proxy.url"

13 },	14 },

14 {	15 {

15 "Address":"2001:0db8:85a3:0000:0000:8a2e:0370:7334",	16 "Address":"2001:0db8:85a3:0000:0000:8a2e:0370:7334",

16 "Gateway":"2001:db8:85a3::7a2e:370:7331",	17 "Gateway":"2001:db8:85a3::7a2e:370:7331",

17 "Method":"ipv6",	18 "Method":"ipv6",

18 "NameServers":[],	19 "NameServers":[],

19 "Prefixlen":12	20 "Prefixlen":12

20 }	21 }

21 ],	22 ],

	23 "SavedIP.Address":"456.456.456.456",
	pneubeck (no reviews) 2014/09/04 12:38:45 better use a valid ipaddress ;-) better use a valid ipaddress ;-) stevenjb 2014/09/04 15:26:21 Done. Show quoted text On 2014/09/04 12:38:45, pneubeck wrote: > better use a valid ipaddress ;-) Done.
	24 "SavedIP.Gateway":"1.1.1.4",

	25 "SavedIP.NameServers":"1.1.1.5,1.1.1.6",
	pneubeck (no reviews) 2014/09/04 12:38:45 i'll file a bug for this to be fixed in Shill i'll file a bug for this to be fixed in Shill stevenjb 2014/09/04 15:26:21 If we are going to "fix" this (I assume you mean c Show quoted text On 2014/09/04 12:38:45, pneubeck wrote: > i'll file a bug for this to be fixed in Shill If we are going to "fix" this (I assume you mean comma-separated -> array), we should just make SavedIP an IPConfig dictionary.
	26 "SavedIP.Prefixlen":25,

	27 "StaticIP.Address":"789.789.789.789",
	pneubeck (no reviews) 2014/09/04 12:38:45 dito dito stevenjb 2014/09/04 15:26:21 Done Show quoted text On 2014/09/04 12:38:45, pneubeck wrote: > dito Done
	28 "StaticIP.Gateway":"1.1.1.7",

	29 "StaticIP.NameServers":"1.1.1.8",

	30 "StaticIP.Prefixlen":26,

22 "Type":"ethernet"	31 "Type":"ethernet"

23 }	32 }

OLD	NEW