Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 540073003: Merge 181007 "Restore SVG filter optimization that was lost in t..." (Closed)

Created:
6 years, 3 months ago by Justin Novosad
Modified:
6 years, 3 months ago
Reviewers:
Stephen White
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Merge 181007 "Restore SVG filter optimization that was lost in t..." > Restore SVG filter optimization that was lost in the deferral switch. > > The legacy filter path does some optimizations to filter bounds in the > case where the filter is known not to affect transparent black, or can > be restricted to a subset of its input rects. Although we should > probably move these optimizations to Skia in the medium term, for now > this change simply invokes them from the deferred path as well. > > This caused some minor pixel diffs at the clip boundaries. > Since many of these same tests were also affected by an > unnecessary snapping to integer pixels (that I've been > meaning to remove -- it makes the results worse, and is > wrong in the pinch-zoom case anyway), I've removed that > here as well. > > BUG=408031 > > Review URL: https://codereview.chromium.org/498073003 TBR=senorblanco@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +28 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Justin Novosad
6 years, 3 months ago (2014-09-04 19:09:31 UTC) #1
Justin Novosad
6 years, 3 months ago (2014-09-04 19:10:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r181391.

Powered by Google App Engine
This is Rietveld 408576698