Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 498073003: Restore SVG filter optimization that was lost in the deferral switch. (Closed)

Created:
6 years, 3 months ago by Stephen White
Modified:
6 years, 3 months ago
Reviewers:
f(malita)
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Restore SVG filter optimization that was lost in the deferral switch. The legacy filter path does some optimizations to filter bounds in the case where the filter is known not to affect transparent black, or can be restricted to a subset of its input rects. Although we should probably move these optimizations to Skia in the medium term, for now this change simply invokes them from the deferred path as well. This caused some minor pixel diffs at the clip boundaries. Since many of these same tests were also affected by an unnecessary snapping to integer pixels (that I've been meaning to remove -- it makes the results worse, and is wrong in the pinch-zoom case anyway), I've removed that here as well. BUG=408031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181007

Patch Set 1 #

Patch Set 2 : Simplify; change comment to reflect reality #

Patch Set 3 : Add another to-be-rebaselined test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen White
senorblanco@chromium.org changed reviewers: + fmalita@chromium.org
6 years, 3 months ago (2014-08-27 22:28:16 UTC) #1
Stephen White
Florin: PTAL. Thanks!
6 years, 3 months ago (2014-08-27 22:40:40 UTC) #2
f(malita)
lgtm
6 years, 3 months ago (2014-08-28 02:16:02 UTC) #3
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 3 months ago (2014-08-28 02:17:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/498073003/40001
6 years, 3 months ago (2014-08-28 02:18:50 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 02:21:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 181007

Powered by Google App Engine
This is Rietveld 408576698