Don't dismiss picture buffers on rez change until they are available

Don't dismiss picture buffers on rez change until they are available

This CL fixes a race where the code would call DismissPictureBuffer()
on all output_picture_buffers_ once it detected a resolution change.
However some of those picture buffers had yet to be displayed by the
client. The client code, when asked to dismiss a picture buffer, only
tries to detect if it is currently displaying that frame, and if not
goes ahead and deletes the texture. This patch defers the dismissing
of the picture buffers until the client calls RecyclePictureBuffer
back with that stale buffer ID, meaning that the texture has been
displayed and can be safely deleted.

TEST: navigate to
http://sr-repro.s3.amazonaws.com/gpudecode/repro-gpu-mbr.html, before
CL there may be series of black frames when playing the video and it
switches from 720p to 1080p. After the CL the black frames are gone.
BUG=404817
Committed: https://crrev.com/9c311d81c7adb0391d596163c5159a0fb41f0cfd
Cr-Commit-Position: refs/heads/master@{#293616}

[luken, 2014-09-04 21:09:28]

luken@chromium.org changed reviewers:
+ scherkus@chromium.org

[ananta, 2014-09-04 21:15:50]

ananta@chromium.org changed reviewers:
+ ananta@chromium.org

[ananta, 2014-09-04 21:15:51]

https://codereview.chromium.org/540043003/diff/20001/content/common/gpu/media...
File content/common/gpu/media/dxva_video_decode_accelerator.cc (right):

https://codereview.chromium.org/540043003/diff/20001/content/common/gpu/media...
content/common/gpu/media/dxva_video_decode_accelerator.cc:576:
client_->DismissPictureBuffer(it->second->id());
Please do this in a task. This may cause problems if we run this code in tests.

[luken, 2014-09-04 21:24:27]

https://codereview.chromium.org/540043003/diff/20001/content/common/gpu/media...
File content/common/gpu/media/dxva_video_decode_accelerator.cc (right):

https://codereview.chromium.org/540043003/diff/20001/content/common/gpu/media...
content/common/gpu/media/dxva_video_decode_accelerator.cc:576:
client_->DismissPictureBuffer(it->second->id());
On 2014/09/04 21:15:51, ananta wrote:
> Please do this in a task. This may cause problems if we run this code in
tests.

Done.

[ananta, 2014-09-04 22:42:53]

https://codereview.chromium.org/540043003/diff/40001/content/common/gpu/media...
File content/common/gpu/media/dxva_video_decode_accelerator.cc (right):

https://codereview.chromium.org/540043003/diff/40001/content/common/gpu/media...
content/common/gpu/media/dxva_video_decode_accelerator.cc:1014:
decoder_.Release();
Please clear the stale_output_picture_buffers_ member here.

[luken, 2014-09-04 22:49:15]

https://codereview.chromium.org/540043003/diff/40001/content/common/gpu/media...
File content/common/gpu/media/dxva_video_decode_accelerator.cc (right):

https://codereview.chromium.org/540043003/diff/40001/content/common/gpu/media...
content/common/gpu/media/dxva_video_decode_accelerator.cc:1014:
decoder_.Release();
On 2014/09/04 22:42:52, ananta wrote:
> Please clear the stale_output_picture_buffers_ member here.

Done.

[scherkus (not reviewing), 2014-09-05 19:54:23]

lgtm

[luken, 2014-09-05 19:55:24]

The CQ bit was checked by luken@chromium.org

[commit-bot: I haz the power, 2014-09-05 19:56:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/luken@chromium.org/540043003/60001

[commit-bot: I haz the power, 2014-09-05 21:58:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 21:58:27]

Exceeded time limit waiting for builds to trigger.

[luken, 2014-09-06 12:17:14]

The CQ bit was checked by luken@chromium.org

[commit-bot: I haz the power, 2014-09-06 12:18:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/luken@chromium.org/540043003/60001

[commit-bot: I haz the power, 2014-09-06 14:14:44]

Committed patchset #4 (id:60001) as 635bbce5d9a5b0061493f5a6adc13e5f310114fb

[commit-bot: I haz the power, 2014-09-10 03:42:34]

Patchset 4 (id:??) landed as
https://crrev.com/9c311d81c7adb0391d596163c5159a0fb41f0cfd
Cr-Commit-Position: refs/heads/master@{#293616}