Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1501)

Issue 540033002: use tryAllocPixels to check the result, allocPixels to require success (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, krit, jbroman, dcheng, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

use tryAllocPixels to check the result, allocPixels to require success This is a pending API change in Skia, but call-sites need to stop relying on the return-result of allocPixels first. Required for chrome CL https://codereview.chromium.org/545513002/ for web/tests TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -43 lines) Patch
M Source/core/frame/ImageBitmapTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/DragImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/DragImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/DeferredImageDecoderTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContextTest.cpp View 25 chunks +28 lines, -28 lines 0 comments Download
M Source/platform/graphics/ImageLayerChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/image-decoders/ImageFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
reed1
6 years, 3 months ago (2014-09-04 14:07:37 UTC) #2
reed1
|| dana
6 years, 3 months ago (2014-09-04 14:57:30 UTC) #4
Stephen Chennney
lgtm
6 years, 3 months ago (2014-09-04 15:06:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/540033002/1
6 years, 3 months ago (2014-09-04 15:06:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/14402)
6 years, 3 months ago (2014-09-04 15:17:01 UTC) #9
Stephen Chennney
Source/web rubber stamp? Would someone care to nominate me for owners on web, so I ...
6 years, 3 months ago (2014-09-04 15:36:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/540033002/1
6 years, 3 months ago (2014-09-04 15:37:52 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 17:06:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181381

Powered by Google App Engine
This is Rietveld 408576698