Source/platform/DragImage.cpp - Issue 540033002: use tryAllocPixels to check the result, allocPixels to require success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/DragImage.cpp

Issue 540033002: use tryAllocPixels to check the result, allocPixels to require success (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/DragImage.cpp

diff --git a/Source/platform/DragImage.cpp b/Source/platform/DragImage.cpp

index 82319cd5fa7df60e5eba1f51b55cf6f35f30ba9f..6e91bfbb6f48f5bbf3e1c2ae5475c437cb6bf68a 100644

--- a/Source/platform/DragImage.cpp

+++ b/Source/platform/DragImage.cpp

@@ -89,7 +89,7 @@ PassOwnPtr<DragImage> DragImage::create(Image* image, RespectImageOrientationEnu

destRect = destRect.transposedRect();

SkBitmap skBitmap;

- if (!skBitmap.allocN32Pixels(sizeRespectingOrientation.width(), sizeRespectingOrientation.height()))

+ if (!skBitmap.tryAllocN32Pixels(sizeRespectingOrientation.width(), sizeRespectingOrientation.height()))

return nullptr;

SkCanvas canvas(skBitmap);

« no previous file with comments | « Source/core/frame/ImageBitmapTest.cpp ('k') | Source/platform/DragImageTest.cpp » ('j') | no next file with comments »