Issue 539943003: Give more meaningful name to m_which in CustomElementLifecycleCallbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 539943003: Give more meaningful name to m_which in CustomElementLifecycleCallbacks (Closed)

Created:
6 years, 3 months ago by deepak.sa

Modified:
6 years, 3 months ago

Reviewers:
esprehn, dominicc (has gone to gerrit)

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Give more meaningful name to m_which in CustomElementLifecycleCallbacks Replace m_which with m_callbackType Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181449

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Source/core/dom/custom/CustomElementLifecycleCallbacks.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/539943003/20001

6 years, 3 months ago (2014-09-05 06:05:30 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-05 07:11:22 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 181449