Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: Source/core/dom/custom/CustomElementLifecycleCallbacks.h

Issue 539943003: Give more meaningful name to m_which in CustomElementLifecycleCallbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed empty BUG= line Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 virtual ~CustomElementLifecycleCallbacks() { } 43 virtual ~CustomElementLifecycleCallbacks() { }
44 44
45 enum CallbackType { 45 enum CallbackType {
46 None = 0, 46 None = 0,
47 CreatedCallback = 1 << 0, 47 CreatedCallback = 1 << 0,
48 AttachedCallback = 1 << 1, 48 AttachedCallback = 1 << 1,
49 DetachedCallback = 1 << 2, 49 DetachedCallback = 1 << 2,
50 AttributeChangedCallback = 1 << 3 50 AttributeChangedCallback = 1 << 3
51 }; 51 };
52 52
53 bool hasCallback(CallbackType type) const { return m_which & type; } 53 bool hasCallback(CallbackType type) const { return m_callbackType & type; }
54 54
55 virtual void created(Element*) = 0; 55 virtual void created(Element*) = 0;
56 virtual void attached(Element*) = 0; 56 virtual void attached(Element*) = 0;
57 virtual void detached(Element*) = 0; 57 virtual void detached(Element*) = 0;
58 virtual void attributeChanged(Element*, const AtomicString& name, const Atom icString& oldValue, const AtomicString& newValue) = 0; 58 virtual void attributeChanged(Element*, const AtomicString& name, const Atom icString& oldValue, const AtomicString& newValue) = 0;
59 59
60 protected: 60 protected:
61 CustomElementLifecycleCallbacks(CallbackType which) : m_which(which) { } 61 CustomElementLifecycleCallbacks(CallbackType type) : m_callbackType(type) { }
62 62
63 private: 63 private:
64 CallbackType m_which; 64 CallbackType m_callbackType;
65 }; 65 };
66 66
67 } 67 }
68 68
69 #endif // CustomElementLifecycleCallbacks_h 69 #endif // CustomElementLifecycleCallbacks_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698