[WIP] DOMMatrixReadOnly::m_matrix is changed to OwnPtr<>.

DOMMatrixReadOnly::m_matrix is changed to OwnPtr<>.

BUG=none
R=haraken

[zino, 2014-09-04 09:25:50]

Patchset #1 (id:1) has been deleted

[zino, 2014-09-04 09:38:15]

Patchset #3 (id:50001) has been deleted

[zino, 2014-09-04 09:59:20]

Dear Haraken,

Please take a look.

I'm not sure but I think TransformationMatrix::multiply() seems to be in
conflict with oilpan when we use SSE2 optimization on debug mode build.
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)

Please see trybot results of Patch Set 2 and Patch Set 3.

So, if you are okay, I'd like to change the m_matrix to OwnPtr<>. (Please see
trybot results of Patch Set 1).

How about you?

[haraken, 2014-09-04 10:38:02]

On 2014/09/04 09:59:20, zino wrote:
> Dear Haraken,
> 
> Please take a look.
> 
> I'm not sure but I think TransformationMatrix::multiply() seems to be in
> conflict with oilpan when we use SSE2 optimization on debug mode build.
>
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)
> 
> Please see trybot results of Patch Set 2 and Patch Set 3.
> 
> So, if you are okay, I'd like to change the m_matrix to OwnPtr<>. (Please see
> trybot results of Patch Set 1).
> 
> How about you?

I don't quite follow your point.

- Why do you need to change m_matrix to OwnPtr?
- What conflicts with oilpan?

[zino, 2014-09-04 10:53:36]

On 2014/09/04 10:38:02, haraken wrote:
> On 2014/09/04 09:59:20, zino wrote:
> > Dear Haraken,
> > 
> > Please take a look.
> > 
> > I'm not sure but I think TransformationMatrix::multiply() seems to be in
> > conflict with oilpan when we use SSE2 optimization on debug mode build.
> >
>
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)
> > 
> > Please see trybot results of Patch Set 2 and Patch Set 3.
> > 
> > So, if you are okay, I'd like to change the m_matrix to OwnPtr<>. (Please
see
> > trybot results of Patch Set 1).
> > 
> > How about you?
> 
> I don't quite follow your point.
> 
> - Why do you need to change m_matrix to OwnPtr?
> - What conflicts with oilpan?

[zino, 2014-09-04 14:18:52]

Sorry for poor explanations.

https://codereview.chromium.org/539923002/diff/30001/Source/core/dom/DOMMatri...
File Source/core/dom/DOMMatrix.cpp (right):

https://codereview.chromium.org/539923002/diff/30001/Source/core/dom/DOMMatri...
Source/core/dom/DOMMatrix.cpp:37: m_matrix.multiply(other->matrix());
I think this sentence is reasonable but it makes a crash on linux_blink_dbg.
(other os and release are okay)

I don't exactly know what the problem is. However, as my investigating,
I guess it occurs if we define TRANSFORMATION_MATRIX_USE_X86_64_SSE2 [1]
and DOMMatrix is derived garbage collected class.
If we don't use garbage collected class, it is okay.

m_matrix.multiply(other->matrix());    // crash
m_matrix = TransformationMatrix(m_matrix).multiply(other->matrix()); // normal

Could you please help me? Am I missing something here?

[1] The code path :
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[zino, 2014-09-16 06:54:06]

On 2014/09/04 14:18:52, zino wrote:
> Sorry for poor explanations.
> 
>
https://codereview.chromium.org/539923002/diff/30001/Source/core/dom/DOMMatri...
> File Source/core/dom/DOMMatrix.cpp (right):
> 
>
https://codereview.chromium.org/539923002/diff/30001/Source/core/dom/DOMMatri...
> Source/core/dom/DOMMatrix.cpp:37: m_matrix.multiply(other->matrix());
> I think this sentence is reasonable but it makes a crash on linux_blink_dbg.
> (other os and release are okay)
> 
> I don't exactly know what the problem is. However, as my investigating,
> I guess it occurs if we define TRANSFORMATION_MATRIX_USE_X86_64_SSE2 [1]
> and DOMMatrix is derived garbage collected class.
> If we don't use garbage collected class, it is okay.
> 
> m_matrix.multiply(other->matrix());    // crash
> m_matrix = TransformationMatrix(m_matrix).multiply(other->matrix()); // normal
> 
> Could you please help me? Am I missing something here?
> 
> [1] The code path :
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Ping Haraken?