Check that Mode is valid for ModeColorFilterEffect

Check that Mode is valid for ModeColorFilterEffect

Committed: http://code.google.com/p/skia/source/detail?r=12131

[robertphillips, 2013-11-05 14:38:17]

lgtm + a suggestion

https://codereview.chromium.org/53983005/diff/20001/src/effects/SkColorFilter...
File src/effects/SkColorFilters.cpp (right):

https://codereview.chromium.org/53983005/diff/20001/src/effects/SkColorFilter...
src/effects/SkColorFilters.cpp:188: static GrEffectRef* Create(const GrColor& c,
SkXfermode::Mode mode) {
It seems like the main reason mode is kept around inside ModeColorFilterEffect
is just to call ModelAsCoeff on it. How about passing srcCoeff and dstCoeff into
the constructor and living without it inside the class?

[bsalomon, 2013-11-05 15:13:28]

On 2013/11/05 14:38:17, robertphillips wrote:
> lgtm + a suggestion
> 
>
https://codereview.chromium.org/53983005/diff/20001/src/effects/SkColorFilter...
> File src/effects/SkColorFilters.cpp (right):
> 
>
https://codereview.chromium.org/53983005/diff/20001/src/effects/SkColorFilter...
> src/effects/SkColorFilters.cpp:188: static GrEffectRef* Create(const GrColor&
c,
> SkXfermode::Mode mode) {
> It seems like the main reason mode is kept around inside ModeColorFilterEffect
> is just to call ModelAsCoeff on it. How about passing srcCoeff and dstCoeff
into
> the constructor and living without it inside the class?

I started doing that and for a reason I don't recall right now it started to
feel more complicated and I backed off. I'll add a TODO.

[commit-bot: I haz the power, 2013-11-05 15:32:28]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/53983005/80001

[commit-bot: I haz the power, 2013-11-05 15:47:51]

Change committed as 12131