Check that Mode is valid for ModeColorFilterEffect

src/effects/SkColorFilters.cpp

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkBlitRow.h"
@@ skipping 168 matching lines @@
     SkAssertResult(SkXfermode::ModeAsCoeff(mode, &filterColorCoeff, &colorCoeff));
     return blend_term(colorCoeff, filterColor, inColor, inColor) +
         blend_term(filterColorCoeff, filterColor, inColor, filterColor);
 }
 
 }
 
 class ModeColorFilterEffect : public GrEffect {
 public:
     static GrEffectRef* Create(const GrColor& c, SkXfermode::Mode mode) {
+        // TODO: Make the effect take the coeffs rather than mode since we already do the
+        // conversion here.
+        SkXfermode::Coeff srcCoeff, dstCoeff;
+        if (!SkXfermode::ModeAsCoeff(mode, &srcCoeff, &dstCoeff)) {
+            SkDebugf("Failing to create color filter for mode %d\n", mode);
+            return NULL;
+        }
         AutoEffectUnref effect(SkNEW_ARGS(ModeColorFilterEffect, (c, mode)));
         return CreateEffectRef(effect);
     }
 
     virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags) const SK_OVERRIDE;
 
     bool willUseFilterColor() const {
         SkXfermode::Coeff dstCoeff;
         SkXfermode::Coeff srcCoeff;
         SkAssertResult(SkXfermode::ModeAsCoeff(fMode, &srcCoeff, &dstCoeff));
@@ skipping 633 matching lines @@
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkModeColorFilter)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(Src_SkModeColorFilter)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SrcOver_SkModeColorFilter)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkLightingColorFilter)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkLightingColorFilter_JustAdd)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkLightingColorFilter_JustMul)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkLightingColorFilter_SingleMul)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkLightingColorFilter_NoPin)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkSimpleColorFilter)
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_END