Issue 539743002: Subzero: Render constants in dump() to be more like LLVM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 539743002: Subzero: Render constants in dump() to be more like LLVM. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth

Modified:
6 years, 3 months ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Render constants in dump() to be more like LLVM. Integers are generally dumped as signed instead of unsigned values. Integers of i1 type are dumped as 'false' and 'true'. Floating point values still don't match LLVM. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cabfa30

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -27 lines)			Patch
M	src/IceConverter.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/IceInst.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/IceOperand.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	szdiff.py	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/64bit.pnacl.ll	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/branch-simple.ll	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll	View	15 chunks	+15 lines, -15 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/select-opt.ll	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

6 years, 3 months ago (2014-09-03 22:19:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as cabfa30 (tree was closed).