Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 539313002: ReadIpHelper: Zero out before calling GetAdaptersAddresses (Closed)

Created:
6 years, 3 months ago by Deprecated (see juliatuttle)
Modified:
6 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ReadIpHelper: Zero out before calling GetAdaptersAddresses This is a first-ditch attempt at fixing http://crbug.com/401655. BUG=401655 Committed: https://crrev.com/469b8770baa97d9d114df4bd97995f60fb9e39fe Cr-Commit-Position: refs/heads/master@{#293610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/dns/dns_config_service_win.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Deprecated (see juliatuttle)
PTAL, mmenke.
6 years, 3 months ago (2014-09-05 19:12:24 UTC) #2
mmenke
LGTM
6 years, 3 months ago (2014-09-05 19:19:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/539313002/1
6 years, 3 months ago (2014-09-05 19:37:09 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 01:37:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/539313002/1
6 years, 3 months ago (2014-09-06 04:34:06 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 10:53:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/539313002/1
6 years, 3 months ago (2014-09-06 13:11:41 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as bae4324156d0b4caac5fe284dfecdb8bed2d7ecb
6 years, 3 months ago (2014-09-06 13:13:23 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/469b8770baa97d9d114df4bd97995f60fb9e39fe
Cr-Commit-Position: refs/heads/master@{#293610}

Powered by Google App Engine
This is Rietveld 408576698