net/dns/dns_config_service_win.cc - Issue 539313002: ReadIpHelper: Zero out before calling GetAdaptersAddresses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_config_service_win.cc

Issue 539313002: ReadIpHelper: Zero out before calling GetAdaptersAddresses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/dns_config_service_win.cc

diff --git a/net/dns/dns_config_service_win.cc b/net/dns/dns_config_service_win.cc

index a2fa2b61272639f5e33e428e7c0fed1ff21671fe..55a2825ff69bec7c202321a791e191e870cc5f96 100644

--- a/net/dns/dns_config_service_win.cc

+++ b/net/dns/dns_config_service_win.cc

@@ -123,6 +123,7 @@ scoped_ptr<IP_ADAPTER_ADDRESSES, base::FreeDeleter> ReadIpHelper(ULONG flags) {

for (unsigned tries = 0; (tries < 3) && (rv == ERROR_BUFFER_OVERFLOW);

tries++) {

out.reset(static_cast<PIP_ADAPTER_ADDRESSES>(malloc(len)));

+ memset(out.get(), 0, len);

rv = GetAdaptersAddresses(AF_UNSPEC, flags, NULL, out.get(), &len);

}

if (rv != NO_ERROR)

« no previous file with comments | « no previous file | no next file » | no next file with comments »