Issue 539003003: Simplify calls to HTMLMediaElement::createMediaControls()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 539003003: Simplify calls to HTMLMediaElement::createMediaControls() (Closed)

Created:
6 years, 3 months ago by fs

Modified:
6 years, 3 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, philipj_slow

CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Simplify calls to HTMLMediaElement::createMediaControls() All calls to the above method is currently guarded by a check of the predicate hasMediaControls(). The first thing createMediaControls() does though is to check the same predicate. Remove the checks at the callsites and leave the checking to createMediaControls(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181403