Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 539003003: Simplify calls to HTMLMediaElement::createMediaControls() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.cpp
diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp
index 91ef6708e6f5e78594ef9b36ad751aec9955cc39..a88f1c5d616b0b6e35f951b263d08ad96a0e6195 100644
--- a/Source/core/html/HTMLMediaElement.cpp
+++ b/Source/core/html/HTMLMediaElement.cpp
@@ -3552,7 +3552,7 @@ void HTMLMediaElement::updateTextTrackDisplay()
{
WTF_LOG(Media, "HTMLMediaElement::updateTextTrackDisplay");
- if (!hasMediaControls() && !createMediaControls())
+ if (!createMediaControls())
return;
mediaControls()->updateTextTrackDisplay();
@@ -3653,7 +3653,7 @@ void HTMLMediaElement::configureMediaControls()
return;
}
- if (!hasMediaControls() && !createMediaControls())
+ if (!createMediaControls())
return;
mediaControls()->reset();
@@ -3686,7 +3686,7 @@ void HTMLMediaElement::configureTextTrackDisplay(VisibilityChangeAssumption assu
if (!m_haveVisibleTextTrack && !hasMediaControls())
return;
- if (!hasMediaControls() && !createMediaControls())
+ if (!createMediaControls())
return;
mediaControls()->changedClosedCaptionsVisibility();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698