Source/web/WebPluginContainerImpl.cpp - Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPluginContainerImpl.cpp

Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPluginContainerImpl.cpp

diff --git a/Source/web/WebPluginContainerImpl.cpp b/Source/web/WebPluginContainerImpl.cpp

index e7ff777142ab50298b963df47ce5cbd78ef49939..48b9532b61a57e64cf20232acc87fdcb34363d55 100644

--- a/Source/web/WebPluginContainerImpl.cpp

+++ b/Source/web/WebPluginContainerImpl.cpp

@@ -436,7 +436,7 @@ v8::Local<v8::Object> WebPluginContainerImpl::v8ObjectForElement()

return v8::Local<v8::Object>();

ScriptState* scriptState = ScriptState::forMainWorld(frame);

- if (scriptState->contextIsEmpty())

+ if (scriptState->contextIsValid())

return v8::Local<v8::Object>();

v8::Handle<v8::Value> v8value = toV8(m_element, scriptState->context()->Global(), scriptState->isolate());

« no previous file with comments | « Source/core/inspector/PageRuntimeAgent.cpp ('k') | no next file » | no next file with comments »