Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: Source/core/inspector/PageRuntimeAgent.cpp

Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorOverlay.cpp ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/PageRuntimeAgent.cpp
diff --git a/Source/core/inspector/PageRuntimeAgent.cpp b/Source/core/inspector/PageRuntimeAgent.cpp
index 4885cdf7a1c7117c21af9edc1a92646143acdfaa..5dccc1356e7b9386582bb6e774ff8548bf0d3762 100644
--- a/Source/core/inspector/PageRuntimeAgent.cpp
+++ b/Source/core/inspector/PageRuntimeAgent.cpp
@@ -170,7 +170,7 @@ void PageRuntimeAgent::frameWindowDiscarded(LocalDOMWindow* window)
Vector<RefPtr<ScriptState> > scriptStatesToRemove;
for (ScriptStateToId::iterator it = m_scriptStateToId.begin(); it != m_scriptStateToId.end(); ++it) {
RefPtr<ScriptState> scriptState = it->key;
- if (scriptState->contextIsEmpty() || window == scriptState->domWindow()) {
+ if (scriptState->contextIsValid() || window == scriptState->domWindow()) {
scriptStatesToRemove.append(scriptState);
m_frontend->executionContextDestroyed(it->value);
}
« no previous file with comments | « Source/core/inspector/InspectorOverlay.cpp ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698