Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 538913002: ServiceWorker: Insert TRACE_EVENT to watch a breakdown of the ServiceWorker's performance on chome:… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary include Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index 67ae2c1f22cbd54e55a0755c32815f1f96331369..82bb676614a6004998bab5df94c7af65cbb7e780 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -572,6 +572,8 @@ void ServiceWorkerVersion::DispatchActivateEventAfterStartWorker(
void ServiceWorkerVersion::OnGetClientDocuments(int request_id) {
std::vector<int> client_ids;
ControlleeByIDMap::iterator it(&controllee_by_id_);
+ TRACE_EVENT0("ServiceWorker",
+ "ServiceWorkerVersion::OnGetClientDocuments");
while (!it.IsAtEnd()) {
client_ids.push_back(it.GetCurrentKey());
it.Advance();
@@ -588,6 +590,8 @@ void ServiceWorkerVersion::OnActivateEventFinished(
blink::WebServiceWorkerEventResult result) {
DCHECK(ACTIVATING == status() ||
REDUNDANT == status()) << status();
+ TRACE_EVENT0("ServiceWorker",
+ "ServiceWorkerVersion::OnActivateEventFinished");
StatusCallback* callback = activate_callbacks_.Lookup(request_id);
if (!callback) {
@@ -609,6 +613,8 @@ void ServiceWorkerVersion::OnInstallEventFinished(
int request_id,
blink::WebServiceWorkerEventResult result) {
DCHECK_EQ(INSTALLING, status()) << status();
+ TRACE_EVENT0("ServiceWorker",
+ "ServiceWorkerVersion::OnInstallEventFinished");
StatusCallback* callback = install_callbacks_.Lookup(request_id);
if (!callback) {
@@ -628,6 +634,9 @@ void ServiceWorkerVersion::OnFetchEventFinished(
int request_id,
ServiceWorkerFetchEventResult result,
const ServiceWorkerResponse& response) {
+ TRACE_EVENT1("ServiceWorker",
+ "ServiceWorkerVersion::OnFetchEventFinished",
+ "Request id", request_id);
FetchCallback* callback = fetch_callbacks_.Lookup(request_id);
if (!callback) {
NOTREACHED() << "Got unexpected message: " << request_id;
@@ -641,6 +650,9 @@ void ServiceWorkerVersion::OnFetchEventFinished(
void ServiceWorkerVersion::OnSyncEventFinished(
int request_id) {
+ TRACE_EVENT1("ServiceWorker",
+ "ServiceWorkerVersion::OnSyncEventFinished",
+ "Request id", request_id);
StatusCallback* callback = sync_callbacks_.Lookup(request_id);
if (!callback) {
NOTREACHED() << "Got unexpected message: " << request_id;
@@ -654,6 +666,9 @@ void ServiceWorkerVersion::OnSyncEventFinished(
void ServiceWorkerVersion::OnPushEventFinished(
int request_id) {
+ TRACE_EVENT1("ServiceWorker",
+ "ServiceWorkerVersion::OnPushEventFinished",
+ "Request id", request_id);
StatusCallback* callback = push_callbacks_.Lookup(request_id);
if (!callback) {
NOTREACHED() << "Got unexpected message: " << request_id;
@@ -669,6 +684,9 @@ void ServiceWorkerVersion::OnPostMessageToDocument(
int client_id,
const base::string16& message,
const std::vector<int>& sent_message_port_ids) {
+ TRACE_EVENT1("ServiceWorker",
+ "ServiceWorkerVersion::OnPostMessageToDocument",
+ "Client id", client_id);
ServiceWorkerProviderHost* provider_host =
controllee_by_id_.Lookup(client_id);
if (!provider_host) {

Powered by Google App Engine
This is Rietveld 408576698