Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: content/browser/service_worker/service_worker_storage.cc

Issue 538913002: ServiceWorker: Insert TRACE_EVENT to watch a breakdown of the ServiceWorker's performance on chome:… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary include Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_storage.cc
diff --git a/content/browser/service_worker/service_worker_storage.cc b/content/browser/service_worker/service_worker_storage.cc
index f838fbeab98c901394e2da245a18c13e61d766b5..c68e63418cf795bc76bebbf3ecf5018f418918a3 100644
--- a/content/browser/service_worker/service_worker_storage.cc
+++ b/content/browser/service_worker/service_worker_storage.cc
@@ -7,7 +7,9 @@
#include <string>
#include "base/bind_helpers.h"
+#include "base/debug/trace_event.h"
#include "base/files/file_util.h"
+#include "base/hash.h"
#include "base/message_loop/message_loop.h"
#include "base/sequenced_task_runner.h"
#include "base/single_thread_task_runner.h"
@@ -250,6 +252,11 @@ void ServiceWorkerStorage::FindRegistrationForDocument(
const GURL& document_url,
const FindRegistrationCallback& callback) {
DCHECK(!document_url.has_ref());
+ TRACE_EVENT_ASYNC_BEGIN1(
+ "ServiceWorker",
+ "ServiceWorkerStorage::FindRegistrationForDocument",
+ base::Hash(document_url.spec()),
+ "URL", document_url.spec());
if (!LazyInitialize(base::Bind(
&ServiceWorkerStorage::FindRegistrationForDocument,
weak_factory_.GetWeakPtr(), document_url, callback))) {
@@ -767,6 +774,11 @@ void ServiceWorkerStorage::DidFindRegistrationForDocument(
ServiceWorkerDatabase::Status status) {
if (status == ServiceWorkerDatabase::STATUS_OK) {
ReturnFoundRegistration(callback, data, resources);
+ TRACE_EVENT_ASYNC_END1(
+ "ServiceWorker",
+ "ServiceWorkerStorage::FindRegistrationForDocument",
+ base::Hash(document_url.spec()),
+ "Status", "OK");
return;
}
@@ -777,12 +789,22 @@ void ServiceWorkerStorage::DidFindRegistrationForDocument(
callback.Run(installing_registration.get() ? SERVICE_WORKER_OK
: SERVICE_WORKER_ERROR_NOT_FOUND,
installing_registration);
+ TRACE_EVENT_ASYNC_END1(
+ "ServiceWorker",
+ "ServiceWorkerStorage::FindRegistrationForDocument",
+ base::Hash(document_url.spec()),
+ "Status", status);
return;
}
ScheduleDeleteAndStartOver();
callback.Run(DatabaseStatusToStatusCode(status),
scoped_refptr<ServiceWorkerRegistration>());
+ TRACE_EVENT_ASYNC_END1(
+ "ServiceWorker",
+ "ServiceWorkerStorage::FindRegistrationForDocument",
+ base::Hash(document_url.spec()),
+ "Status", status);
}
void ServiceWorkerStorage::DidFindRegistrationForPattern(

Powered by Google App Engine
This is Rietveld 408576698