Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: content/browser/service_worker/service_worker_read_from_cache_job.cc

Issue 538913002: ServiceWorker: Insert TRACE_EVENT to watch a breakdown of the ServiceWorker's performance on chome:… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary include Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_read_from_cache_job.cc
diff --git a/content/browser/service_worker/service_worker_read_from_cache_job.cc b/content/browser/service_worker/service_worker_read_from_cache_job.cc
index fab8d802a4a4d0cdc0e6f4d1703ea0acdf2bff91..07f47e1101697e00d931f23a6e1ff0748b44e912 100644
--- a/content/browser/service_worker/service_worker_read_from_cache_job.cc
+++ b/content/browser/service_worker/service_worker_read_from_cache_job.cc
@@ -7,6 +7,7 @@
#include <string>
#include <vector>
+#include "base/debug/trace_event.h"
#include "content/browser/service_worker/service_worker_context_core.h"
#include "content/browser/service_worker/service_worker_disk_cache.h"
#include "content/browser/service_worker/service_worker_metrics.h"
@@ -36,6 +37,10 @@ ServiceWorkerReadFromCacheJob::~ServiceWorkerReadFromCacheJob() {
}
void ServiceWorkerReadFromCacheJob::Start() {
+ TRACE_EVENT_ASYNC_BEGIN1("ServiceWorker",
+ "ServiceWorkerReadFromCacheJob::ReadInfo",
+ this,
+ "URL", request_->url().spec());
if (!context_) {
NotifyStartError(net::URLRequestStatus(
net::URLRequestStatus::FAILED, net::ERR_FAILED));
@@ -119,6 +124,10 @@ bool ServiceWorkerReadFromCacheJob::ReadRawData(
DCHECK_NE(buf_size, 0);
DCHECK(bytes_read);
DCHECK(!reader_->IsReadPending());
+ TRACE_EVENT_ASYNC_BEGIN1("ServiceWorker",
+ "ServiceWorkerReadFromCacheJob::ReadRawData",
+ this,
+ "URL", request_->url().spec());
reader_->ReadData(
buf, buf_size, base::Bind(&ServiceWorkerReadFromCacheJob::OnReadComplete,
weak_factory_.GetWeakPtr()));
@@ -149,6 +158,10 @@ void ServiceWorkerReadFromCacheJob::OnReadInfoComplete(int result) {
if (is_range_request())
SetupRangeResponse(http_info_io_buffer_->response_data_size);
http_info_io_buffer_ = NULL;
+ TRACE_EVENT_ASYNC_END1("ServiceWorker",
+ "ServiceWorkerReadFromCacheJob::ReadInfo",
+ this,
+ "Result", result);
NotifyHeadersComplete();
}
@@ -189,6 +202,10 @@ void ServiceWorkerReadFromCacheJob::OnReadComplete(int result) {
}
ServiceWorkerMetrics::CountReadResponseResult(check_result);
NotifyReadComplete(result);
+ TRACE_EVENT_ASYNC_END1("ServiceWorker",
+ "ServiceWorkerReadFromCacheJob::ReadRawData",
+ this,
+ "Result", result);
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698