Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: runtime/lib/mirrors.cc

Issue 53883002: Ensure constructorName symbols include private manglings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/mirrors_impl.dart » ('j') | runtime/lib/mirrors_patch.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index 22b2d47fa4b2ea1c81d9c35b3526026b3b24293d..eb611dfd1887441e90b2bc9283a5e7f932ad2149 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -893,6 +893,7 @@ DEFINE_NATIVE_ENTRY(Mirrors_makeLocalTypeMirror, 1) {
return CreateTypeMirror(type);
}
+
DEFINE_NATIVE_ENTRY(Mirrors_mangleName, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(1));
@@ -900,18 +901,6 @@ DEFINE_NATIVE_ENTRY(Mirrors_mangleName, 2) {
return lib.IsPrivate(name) ? lib.PrivateName(name) : name.raw();
}
-DEFINE_NATIVE_ENTRY(Mirrors_unmangleName, 1) {
- GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(0));
- // It would be nice to unconditionally use IdentifierPrettyName, alas it
- // cannot cope with the symbols for the names of anonymous mixin applications.
- if (Library::IsPrivate(name) ||
- Field::IsGetterName(name) ||
- Field::IsSetterName(name)) {
- return String::IdentifierPrettyName(name);
- }
- return name.raw();
-}
-
DEFINE_NATIVE_ENTRY(MirrorReference_equals, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, a, arguments->NativeArgAt(0));
« no previous file with comments | « no previous file | runtime/lib/mirrors_impl.dart » ('j') | runtime/lib/mirrors_patch.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698