runtime/lib/mirrors_impl.dart - Issue 53883002: Ensure constructorName symbols include private manglings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 53883002: Ensure constructorName symbols include private manglings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/mirrors_impl.dart

diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart

index a2ab082698353683625dd7195acd806f3046f56c..c37c0496d0d74231f72b6947e731588cfd54eb0b 100644

--- a/runtime/lib/mirrors_impl.dart

+++ b/runtime/lib/mirrors_impl.dart

@@ -1244,7 +1244,8 @@ class _LocalMethodMirrorImpl extends _LocalDeclarationMirrorImpl

'Internal error in MethodMirror.constructorName: '

'malformed name <$simpleName>');

} else if (parts.length == 2) {

- _constructorName = _s(parts[1]);

+ LibraryMirror definingLibrary = owner.owner;

+ _constructorName = MirrorSystem.getSymbol(parts[1], definingLibrary);

} else {

_constructorName = _s('');

}

« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/lib/mirrors_patch.dart » ('j') | runtime/lib/mirrors_patch.dart » ('J')