Chromium Code Reviews
Help | Chromium Project | Sign in
(897)

Issue 5386001: Cache certificate verification results in memory. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
eroman, agl, willchan
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, Alpha, Sergey Ulanov, amit, ben+cc_chromium.org, dmac, pam+watch_chromium.org, awong, garykac, PaweĊ‚ Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Cache certificate verification results in memory.

R=agl
BUG=63357
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69414

Patch Set 1 #

Patch Set 2 : Add unit tests. Ready for review. #

Total comments: 29

Patch Set 3 : Sync with ToT. Increase cache size to 256. #

Patch Set 4 : GetCacheSize returns size_t. Fix cert_verifier_unittest.cc compilation errors. #

Patch Set 5 : Upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1139 lines, -208 lines) Lint Patch
M chrome/browser/io_thread.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/io_thread.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/net/chrome_url_request_context.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/net/chrome_url_request_context.cc View 1 2 3 4 chunks +4 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/net/connection_tester.cc View 1 2 3 3 chunks +5 lines, -2 lines 0 comments 0 errors Download
M chrome/service/net/service_url_request_context.cc View 1 2 3 4 chunks +4 lines, -0 lines 0 comments 0 errors Download
M chrome/test/plugin/plugin_test.cpp View 1 2 3 3 chunks +5 lines, -0 lines 0 comments 1 errors Download
M chrome_frame/metrics_service.cc View 1 2 3 5 chunks +6 lines, -1 line 0 comments 1 errors Download
M chrome_frame/test/test_server_test.cc View 1 2 3 3 chunks +4 lines, -0 lines 0 comments 0 errors Download
M jingle/notifier/base/chrome_async_socket.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M jingle/notifier/base/xmpp_client_socket_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments 0 errors Download
M jingle/notifier/base/xmpp_client_socket_factory.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M net/base/cert_verifier.h View 1 2 3 3 chunks +164 lines, -20 lines 0 comments 0 errors Download
M net/base/cert_verifier.cc View 1 2 3 2 chunks +414 lines, -91 lines 0 comments 1 errors Download
A net/base/cert_verifier_unittest.cc View 1 2 3 1 chunk +260 lines, -0 lines 0 comments 1 errors Download
MM net/http/disk_cache_based_ssl_host_info.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments 0 errors Download
M net/http/http_cache.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments 0 errors Download
M net/http/http_cache.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments 0 errors Download
M net/http/http_network_layer.h View 1 2 3 6 chunks +11 lines, -5 lines 0 comments 0 errors Download
M net/http/http_network_layer.cc View 1 2 3 9 chunks +10 lines, -1 line 0 comments 0 errors Download
M net/http/http_network_layer_unittest.cc View 1 2 3 4 chunks +7 lines, -0 lines 0 comments 0 errors Download
M net/http/http_network_session.h View 1 2 3 4 chunks +4 lines, -0 lines 0 comments 0 errors Download
M net/http/http_network_session.cc View 1 2 3 3 chunks +3 lines, -0 lines 0 comments 0 errors Download
M net/http/http_network_transaction_unittest.cc View 1 2 3 6 chunks +8 lines, -2 lines 0 comments 0 errors Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 2 3 3 chunks +4 lines, -0 lines 0 comments 0 errors Download
M net/http/http_response_body_drainer_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments 0 errors Download
MM net/http/http_stream_factory_unittest.cc View 1 2 3 5 chunks +6 lines, -1 line 0 comments 0 errors Download
M net/net.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 2 3 1 chunk +5 lines, -2 lines 0 comments 0 errors Download
M net/socket/client_socket_factory.h View 1 2 3 4 chunks +5 lines, -1 line 0 comments 0 errors Download
M net/socket/client_socket_factory.cc View 1 2 3 3 chunks +11 lines, -7 lines 0 comments 0 errors Download
M net/socket/client_socket_pool_base_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments 0 errors Download
MM net/socket/client_socket_pool_manager.h View 1 2 3 5 chunks +7 lines, -4 lines 0 comments 1 errors Download
M net/socket/client_socket_pool_manager.cc View 1 2 3 5 chunks +5 lines, -0 lines 0 comments 0 errors Download
M net/socket/socket_test_util.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments 0 errors Download
M net/socket/socket_test_util.cc View 1 2 3 3 chunks +3 lines, -1 line 0 comments 0 errors Download
M net/socket/ssl_client_socket_mac.h View 1 2 3 3 chunks +5 lines, -2 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_mac.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_mac_factory.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_mac_factory.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments 0 errors Download
M net/socket/ssl_client_socket_nss.h View 1 2 3 3 chunks +4 lines, -1 line 0 comments 0 errors Download
M net/socket/ssl_client_socket_nss.cc View 1 2 3 3 chunks +3 lines, -1 line 0 comments 0 errors Download
M net/socket/ssl_client_socket_nss_factory.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_nss_factory.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M net/socket/ssl_client_socket_openssl.h View 1 2 3 3 chunks +5 lines, -2 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_openssl.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_pool.h View 1 2 3 6 chunks +7 lines, -1 line 0 comments 0 errors Download
M net/socket/ssl_client_socket_pool.cc View 1 2 3 8 chunks +11 lines, -5 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_pool_unittest.cc View 1 2 3 4 chunks +6 lines, -1 line 0 comments 1 errors Download
M net/socket/ssl_client_socket_snapstart_unittest.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_unittest.cc View 1 2 3 13 chunks +37 lines, -21 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_win.h View 1 2 3 3 chunks +5 lines, -2 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_win.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments 0 errors Download
M net/socket/ssl_host_info.h View 1 2 3 3 chunks +5 lines, -3 lines 0 comments 0 errors Download
MM net/socket/ssl_host_info.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments 0 errors Download
M net/socket/tcp_client_socket_pool_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments 0 errors Download
M net/socket_stream/socket_stream.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M net/socket_stream/socket_stream.cc View 1 2 3 3 chunks +5 lines, -1 line 0 comments 0 errors Download
M net/spdy/spdy_test_util.h View 1 2 3 9 chunks +9 lines, -0 lines 0 comments 0 errors Download
M net/tools/fetch/fetch_client.cc View 1 2 3 4 chunks +7 lines, -3 lines 0 comments 0 errors Download
M net/url_request/url_request_context.h View 1 2 3 3 chunks +6 lines, -0 lines 0 comments 0 errors Download
MM net/url_request/url_request_context.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M net/url_request/url_request_unittest.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments 0 errors Download
M remoting/jingle_glue/ssl_socket_adapter.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M webkit/tools/test_shell/test_shell_request_context.cc View 1 2 3 4 chunks +6 lines, -3 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 6
wtc
Please review this CL in the following order. 1. cert_verifier.{h,cc} cert_verifier_unittest.cc The code is primarily ...
3 years, 4 months ago #1
willchan
Drive by comments :) http://codereview.chromium.org/5386001/diff/52001/chrome/browser/io_thread.h File chrome/browser/io_thread.h (right): http://codereview.chromium.org/5386001/diff/52001/chrome/browser/io_thread.h#newcode48 chrome/browser/io_thread.h:48: scoped_ptr<net::CertVerifier> cert_verifier; I think you ...
3 years, 4 months ago #2
willchan
Oops, I forgot to mention the main reason I looked at this. I was curious ...
3 years, 4 months ago #3
agl
I expect that there will be a another round to address willchan's comments. I agree ...
3 years, 4 months ago #4
wtc
Please review Patch Set 4. You can just review the diffs between Patch Sets 2 ...
3 years, 4 months ago #5
agl
3 years, 3 months ago #6
Have looked at the differences from patch set 2 for those three files. LGTM.
Again, if this hasn't landed yet then I fear for the bit-rot :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6