Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: net/socket/ssl_client_socket_snapstart_unittest.cc

Issue 5386001: Cache certificate verification results in memory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Upload before checkin Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | net/socket/ssl_client_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_snapstart_unittest.cc
===================================================================
--- net/socket/ssl_client_socket_snapstart_unittest.cc (revision 69359)
+++ net/socket/ssl_client_socket_snapstart_unittest.cc (working copy)
@@ -41,8 +41,8 @@
// pretends that certificate verification always succeeds.
class TestSSLHostInfo : public SSLHostInfo {
public:
- TestSSLHostInfo()
- : SSLHostInfo("example.com", kDefaultSSLConfig) {
+ explicit TestSSLHostInfo(CertVerifier* cert_verifier)
+ : SSLHostInfo("example.com", kDefaultSSLConfig, cert_verifier) {
if (!saved_.empty())
Parse(saved_);
cert_verification_complete_ = true;
@@ -194,7 +194,7 @@
scoped_ptr<SSLClientSocket> sock(
socket_factory_->CreateSSLClientSocket(
transport, HostPortPair("example.com", 443), ssl_config_,
- new TestSSLHostInfo()));
+ new TestSSLHostInfo(&cert_verifier_), &cert_verifier_));
TestCompletionCallback callback;
int rv = sock->Connect(&callback);
@@ -265,6 +265,7 @@
}
base::ProcessHandle child_;
+ CertVerifier cert_verifier_;
ClientSocketFactory* const socket_factory_;
struct sockaddr_in remote_;
int client_;
« no previous file with comments | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | net/socket/ssl_client_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698