Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 538203002: Fix a crash on WebViewFocusHelper destruction. (Closed)

Created:
6 years, 3 months ago by msw
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tfarina, Lei Zhang, Mike Wittman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a crash on WebViewFocusHelper destruction. Remove WebViewFocusHelper; r287082 had object lifetime issues. Fix Issue 368691 with a WebDialogWebContentsDelegate instead: Remove CreateConstrainedWebDialog's |tab_delegate| parameter. Delete the custom PrintPreviewWebContentDelegate subclass. Add a consolidated WebDialogWebContentsDelegateViews instead. (ensures WebView focus and forwards dialog shortcut keys) TODO(followup): Additional WebUI dialog creation cleanup. BUG=410158, 368691 TEST="Show as tab" doesn't crash popups with print dialogs. Focusing print dialog <-> omnibox works. R=ben@chromium.org Committed: https://crrev.com/4db9fd60d24d06580dbff65fa648a2515e599e22 Cr-Commit-Position: refs/heads/master@{#293961}

Patch Set 1 #

Patch Set 2 : Remove explicit reset in WindowClosing; cleanup. #

Patch Set 3 : Re-add the explicit reset in WindowClosing. #

Patch Set 4 : Attempting to fix the defect differently. #

Patch Set 5 : Add a WebDialogWebContentsDelegateViews instead. #

Patch Set 6 : Fix build; cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -159 lines) Patch
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 2 3 4 5 5 chunks +9 lines, -61 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 1 2 3 4 5 4 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 2 3 4 5 6 chunks +51 lines, -67 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 1 2 3 4 5 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.h View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
msw
Hey Ben, please take a look; thanks!
6 years, 3 months ago (2014-09-08 21:34:59 UTC) #6
Ben Goodger (Google)
lgtm
6 years, 3 months ago (2014-09-09 16:03:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/538203002/180001
6 years, 3 months ago (2014-09-09 16:53:45 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:180001) as 6eac0438153f5ebab2608ce7cb2a8fa8d8135410
6 years, 3 months ago (2014-09-09 17:30:31 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:06 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/4db9fd60d24d06580dbff65fa648a2515e599e22
Cr-Commit-Position: refs/heads/master@{#293961}

Powered by Google App Engine
This is Rietveld 408576698