DescriptionFix a crash on WebViewFocusHelper destruction.
Remove WebViewFocusHelper; r287082 had object lifetime issues.
Fix Issue 368691 with a WebDialogWebContentsDelegate instead:
Remove CreateConstrainedWebDialog's |tab_delegate| parameter.
Delete the custom PrintPreviewWebContentDelegate subclass.
Add a consolidated WebDialogWebContentsDelegateViews instead.
(ensures WebView focus and forwards dialog shortcut keys)
TODO(followup): Additional WebUI dialog creation cleanup.
BUG=410158, 368691
TEST="Show as tab" doesn't crash popups with print dialogs. Focusing print dialog <-> omnibox works.
R=ben@chromium.org
Committed: https://crrev.com/4db9fd60d24d06580dbff65fa648a2515e599e22
Cr-Commit-Position: refs/heads/master@{#293961}
Patch Set 1 #Patch Set 2 : Remove explicit reset in WindowClosing; cleanup. #Patch Set 3 : Re-add the explicit reset in WindowClosing. #Patch Set 4 : Attempting to fix the defect differently. #Patch Set 5 : Add a WebDialogWebContentsDelegateViews instead. #Patch Set 6 : Fix build; cleanup. #
Messages
Total messages: 11 (6 generated)
|