chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc - Issue 538203002: Fix a crash on WebViewFocusHelper destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc

Issue 538203002: Fix a crash on WebViewFocusHelper destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build; cleanup. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc

diff --git a/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc b/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc

index 906e9847e38fc515486627c4db69f72558b009d0..8fe4d8367e8bd83e32612e4d6561f5df993ac84b 100644

--- a/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc

+++ b/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc

@@ -151,8 +151,7 @@ void ProfileSigninConfirmationDialog::Close() const {

void ProfileSigninConfirmationDialog::Show(bool prompt) {

prompt_for_new_profile_ = prompt;

- dialog_delegate_ =

- CreateConstrainedWebDialog(profile_, this, NULL, web_contents_);

+ dialog_delegate_ = CreateConstrainedWebDialog(profile_, this, web_contents_);

}

ui::ModalType ProfileSigninConfirmationDialog::GetDialogModalType() const {

« no previous file with comments | « chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc ('k') | no next file » | no next file with comments »