[Password Generation] Remove old UI

[Password Generation] Remove old UI

BUG=347777
Committed: https://crrev.com/9f749456f195f5042dc9827241c10dbe7fc24801
Cr-Commit-Position: refs/heads/master@{#294442}

[Garrett Casto, 2014-09-06 00:01:46]

gcasto@chromium.org changed reviewers:
+ msw@chromium.org, shess@chromium.org

[Garrett Casto, 2014-09-06 00:01:47]

msw: Please review chrome/browser/ui/views/*
shess: Please review chrome/browser/ui/cocoa/*

[Garrett Casto, 2014-09-06 00:03:23]

gcasto@chromium.org changed reviewers:
- shess@chromium.org

[Garrett Casto, 2014-09-06 00:03:24]

Actually, looks I don't need a review from Scott.

[msw, 2014-09-06 02:15:27]

Could you audit the remaining c/b/.*password.* files?
(sorry, it's hard for me to tell new files from old)

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_window.h (right):

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/browse...
chrome/browser/ui/browser_window.h:36: class PasswordGenerator;
Remove these forward declarations and the autofill namespace.

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:20: #include
"chrome/browser/password_manager/chrome_password_manager_client.h"
Can this be removed?

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:52: #include
"components/autofill/core/common/password_form.h"
Remove this.

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_view.cc:26: #include
"chrome/browser/password_manager/chrome_password_manager_client.h"
Can this be removed?

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_view.cc:104: #include
"components/password_manager/core/browser/password_manager.h"
Can this be removed?

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/browser_view.h (right):

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_view.h:69: class PasswordGenerator;
Remove this and the autofill namespace.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
File chrome/chrome_browser_ui.gypi (left):

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:562:
'browser/ui/cocoa/location_bar/manage_passwords_decoration.h',
Is this still in use?

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:2173:
'browser/ui/views/passwords/manage_password_item_view.cc',
Are these other c/b/ui/views/passwords/* files still in use?

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:108:
'browser/ui/autofill/password_generation_popup_controller_impl.cc',
Are these still needed?

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:249:
'browser/ui/cocoa/autofill/password_generation_popup_view_bridge.h',
Are these still needed?

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:628:
'browser/ui/cocoa/passwords/manage_password_item_view_controller.h',
are these c/b/ui/cocoa/passwords files still in use?

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:818:
'browser/ui/passwords/manage_passwords_bubble.cc',
Are these c/b/ui/passwords/* files still in use?

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:1100:
'browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc',
ditto

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:1748:
'browser/ui/webui/options/password_manager_handler.cc',
ditto

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:1912:
'browser/ui/views/autofill/password_generation_popup_view_views.cc',
ditto

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:2571:
'../components/components.gyp:password_manager_core_browser',
ditto

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:84:
'browser/password_manager/password_generation_interactive_uitest.cc',
Is this still needed?

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:879:
'../components/autofill/content/renderer/test_password_generation_agent.h',
Are these still needed?

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:1413:
'browser/ui/autofill/password_generation_popup_view_browsertest.cc',
Are these still needed?

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:1478:
'browser/ui/views/autofill/password_generation_popup_view_tester_views.cc',
Are these still needed?

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:1572:
'renderer/autofill/password_generation_agent_browsertest.cc',
Is this still needed?

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:2177:
'../components/autofill/content/renderer/test_password_generation_agent.cc',
ditto

[Garrett Casto, 2014-09-10 00:10:17]

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:20: #include
"chrome/browser/password_manager/chrome_password_manager_client.h"
On 2014/09/06 02:15:25, msw wrote:
> Can this be removed?

Done.

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:52: #include
"components/autofill/core/common/password_form.h"
On 2014/09/06 02:15:25, msw wrote:
> Remove this.

Done.

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_view.cc:26: #include
"chrome/browser/password_manager/chrome_password_manager_client.h"
On 2014/09/06 02:15:26, msw wrote:
> Can this be removed?

Yes, done.

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_view.cc:104: #include
"components/password_manager/core/browser/password_manager.h"
On 2014/09/06 02:15:26, msw wrote:
> Can this be removed?

Done.

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/browser_view.h (right):

https://codereview.chromium.org/538173002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_view.h:69: class PasswordGenerator;
On 2014/09/06 02:15:26, msw wrote:
> Remove this and the autofill namespace.

Done.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
File chrome/chrome_browser_ui.gypi (left):

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:562:
'browser/ui/cocoa/location_bar/manage_passwords_decoration.h',
On 2014/09/06 02:15:26, msw wrote:
> Is this still in use?

Yes, this is the save passwords bubble.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:2173:
'browser/ui/views/passwords/manage_password_item_view.cc',
On 2014/09/06 02:15:26, msw wrote:
> Are these other c/b/ui/views/passwords/* files still in use?

Yes, save passwords bubble.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:108:
'browser/ui/autofill/password_generation_popup_controller_impl.cc',
On 2014/09/06 02:15:26, msw wrote:
> Are these still needed?

Yes, this is the new generation implementation.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:249:
'browser/ui/cocoa/autofill/password_generation_popup_view_bridge.h',
On 2014/09/06 02:15:26, msw wrote:
> Are these still needed?

Yes, new generation implementation.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:628:
'browser/ui/cocoa/passwords/manage_password_item_view_controller.h',
On 2014/09/06 02:15:26, msw wrote:
> are these c/b/ui/cocoa/passwords files still in use?

Yes, save passwords bubble.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:818:
'browser/ui/passwords/manage_passwords_bubble.cc',
On 2014/09/06 02:15:26, msw wrote:
> Are these c/b/ui/passwords/* files still in use?

Yes, save passwords bubble.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:1100:
'browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc',
On 2014/09/06 02:15:26, msw wrote:
> ditto

Yes, this is chrome://password-manager-internals

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:1748:
'browser/ui/webui/options/password_manager_handler.cc',
On 2014/09/06 02:15:26, msw wrote:
> ditto

Yes, this is chrome://passwords

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:1912:
'browser/ui/views/autofill/password_generation_popup_view_views.cc',
On 2014/09/06 02:15:26, msw wrote:
> ditto

Yes, this is the new generation implementation.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:2571:
'../components/components.gyp:password_manager_core_browser',
On 2014/09/06 02:15:26, msw wrote:
> ditto

Yes.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:84:
'browser/password_manager/password_generation_interactive_uitest.cc',
On 2014/09/06 02:15:27, msw wrote:
> Is this still needed?

Yes

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:879:
'../components/autofill/content/renderer/test_password_generation_agent.h',
On 2014/09/06 02:15:26, msw wrote:
> Are these still needed?

Yep.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:1413:
'browser/ui/autofill/password_generation_popup_view_browsertest.cc',
On 2014/09/06 02:15:26, msw wrote:
> Are these still needed?

Yep.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:1478:
'browser/ui/views/autofill/password_generation_popup_view_tester_views.cc',
On 2014/09/06 02:15:26, msw wrote:
> Are these still needed?

Yep.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:1572:
'renderer/autofill/password_generation_agent_browsertest.cc',
On 2014/09/06 02:15:27, msw wrote:
> Is this still needed?

Yes.

https://codereview.chromium.org/538173002/diff/20001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:2177:
'../components/autofill/content/renderer/test_password_generation_agent.cc',
On 2014/09/06 02:15:26, msw wrote:
> ditto

Needed.

[Garrett Casto, 2014-09-10 00:11:21]

gcasto@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Garrett Casto, 2014-09-10 00:11:21]

+phajdan for chrome/test/* cleanup.

[msw, 2014-09-10 00:16:21]

Thanks for going over all my comments; lgtm!

[Paweł Hajdan Jr., 2014-09-11 09:15:09]

chrome/test LGTM

[Garrett Casto, 2014-09-11 18:08:03]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-09-11 18:09:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/538173002/60001

[commit-bot: I haz the power, 2014-09-11 19:27:07]

Committed patchset #4 (id:60001) as bbea421ad3c71f9a2727382785c78f756531c59e

[commit-bot: I haz the power, 2014-09-11 19:40:37]

Patchset 4 (id:??) landed as
https://crrev.com/9f749456f195f5042dc9827241c10dbe7fc24801
Cr-Commit-Position: refs/heads/master@{#294442}