[Password Generation] Remove old UI

chrome/chrome_browser_ui.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chrome_browser_ui_non_ios_sources': [
       'browser/ui/accelerator_utils.h',
       'browser/ui/android/android_about_app_info.cc',
       'browser/ui/android/android_about_app_info.h',
@@ skipping 87 matching lines @@
       'browser/ui/autofill/autofill_popup_controller_impl.h',
       'browser/ui/autofill/autofill_popup_view.h',
       'browser/ui/autofill/autofill_popup_view_delegate.h',
       'browser/ui/autofill/chrome_autofill_client.cc',
       'browser/ui/autofill/chrome_autofill_client.h',
       'browser/ui/autofill/chrome_autofill_client_mac.mm',
       'browser/ui/autofill/country_combobox_model.cc',
       'browser/ui/autofill/country_combobox_model.h',
       'browser/ui/autofill/loading_animation.cc',
       'browser/ui/autofill/loading_animation.h',
       'browser/ui/autofill/password_generation_popup_controller_impl.cc',

[msw, 2014/09/06 02:15:26]

Are these still needed?

[Garrett Casto, 2014/09/10 00:10:17]

Yes, this is the new generation implementation.

       'browser/ui/autofill/password_generation_popup_controller_impl.h',
       'browser/ui/autofill/password_generation_popup_controller.h',
       'browser/ui/autofill/password_generation_popup_observer.h',
       'browser/ui/autofill/password_generation_popup_view.cc',
       'browser/ui/autofill/password_generation_popup_view.h',
       'browser/ui/autofill/popup_controller_common.cc',
       'browser/ui/autofill/popup_controller_common.h',
       'browser/ui/blocked_content/blocked_window_params.cc',
       'browser/ui/blocked_content/blocked_window_params.h',
       'browser/ui/blocked_content/popup_blocker_tab_helper.cc',
@@ skipping 120 matching lines @@
       'browser/ui/cocoa/autofill/autofill_tooltip_controller.h',
       'browser/ui/cocoa/autofill/autofill_tooltip_controller.mm',
       'browser/ui/cocoa/autofill/down_arrow_popup_menu_cell.h',
       'browser/ui/cocoa/autofill/down_arrow_popup_menu_cell.mm',
       'browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.h',
       'browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.mm',
       'browser/ui/cocoa/autofill/layout_view.h',
       'browser/ui/cocoa/autofill/layout_view.mm',
       'browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.h',
       'browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm',
       'browser/ui/cocoa/autofill/password_generation_popup_view_bridge.h',

[msw, 2014/09/06 02:15:26]

Are these still needed?

[Garrett Casto, 2014/09/10 00:10:17]

Yes, new generation implementation.

       'browser/ui/cocoa/autofill/password_generation_popup_view_bridge.mm',
       'browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h',
       'browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm',
       'browser/ui/cocoa/autofill/simple_grid_layout.h',
       'browser/ui/cocoa/autofill/simple_grid_layout.mm',
       'browser/ui/cocoa/background_gradient_view.h',
       'browser/ui/cocoa/background_gradient_view.mm',
       'browser/ui/cocoa/base_bubble_controller.h',
       'browser/ui/cocoa/base_bubble_controller.mm',
       'browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.h',
@@ skipping 41 matching lines @@
       'browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h',
       'browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm',
       'browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.h',
       'browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm',
       'browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.h',
       'browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm',
       'browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.h',
       'browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.mm',
       'browser/ui/cocoa/browser/edit_search_engine_cocoa_controller.h',
       'browser/ui/cocoa/browser/edit_search_engine_cocoa_controller.mm',
-      'browser/ui/cocoa/browser/password_generation_bubble_controller.h',
-      'browser/ui/cocoa/browser/password_generation_bubble_controller.mm',
       'browser/ui/cocoa/browser/zoom_bubble_controller.h',
       'browser/ui/cocoa/browser/zoom_bubble_controller.mm',
       'browser/ui/cocoa/browser_command_executor.h',
       'browser/ui/cocoa/browser_window_cocoa.h',
       'browser/ui/cocoa/browser_window_cocoa.mm',
       'browser/ui/cocoa/browser_window_controller.h',
       'browser/ui/cocoa/browser_window_controller.mm',
       'browser/ui/cocoa/browser_window_controller_private.h',
       'browser/ui/cocoa/browser_window_controller_private.mm',
       'browser/ui/cocoa/browser_window_factory.mm',
@@ skipping 229 matching lines @@
       'browser/ui/cocoa/location_bar/image_decoration.h',
       'browser/ui/cocoa/location_bar/image_decoration.mm',
       'browser/ui/cocoa/location_bar/keyword_hint_decoration.h',
       'browser/ui/cocoa/location_bar/keyword_hint_decoration.mm',
       'browser/ui/cocoa/location_bar/location_bar_decoration.h',
       'browser/ui/cocoa/location_bar/location_bar_decoration.mm',
       'browser/ui/cocoa/location_bar/location_bar_view_mac.h',
       'browser/ui/cocoa/location_bar/location_bar_view_mac.mm',
       'browser/ui/cocoa/location_bar/location_icon_decoration.h',
       'browser/ui/cocoa/location_bar/location_icon_decoration.mm',
       'browser/ui/cocoa/location_bar/manage_passwords_decoration.h',

[msw, 2014/09/06 02:15:26]

Is this still in use?

[Garrett Casto, 2014/09/10 00:10:17]

Yes, this is the save passwords bubble.

       'browser/ui/cocoa/location_bar/manage_passwords_decoration.mm',
       'browser/ui/cocoa/location_bar/mic_search_decoration.h',
       'browser/ui/cocoa/location_bar/mic_search_decoration.mm',
       'browser/ui/cocoa/location_bar/origin_chip_decoration.h',
       'browser/ui/cocoa/location_bar/origin_chip_decoration.mm',
       'browser/ui/cocoa/location_bar/page_action_decoration.h',
       'browser/ui/cocoa/location_bar/page_action_decoration.mm',
       'browser/ui/cocoa/location_bar/search_button_decoration.h',
       'browser/ui/cocoa/location_bar/search_button_decoration.mm',
       'browser/ui/cocoa/location_bar/selected_keyword_decoration.h',
@@ skipping 47 matching lines @@
       'browser/ui/cocoa/panels/panel_cocoa.h',
       'browser/ui/cocoa/panels/panel_cocoa.mm',
       'browser/ui/cocoa/panels/panel_stack_window_cocoa.h',
       'browser/ui/cocoa/panels/panel_stack_window_cocoa.mm',
       'browser/ui/cocoa/panels/panel_titlebar_view_cocoa.h',
       'browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm',
       'browser/ui/cocoa/panels/panel_utils_cocoa.h',
       'browser/ui/cocoa/panels/panel_utils_cocoa.mm',
       'browser/ui/cocoa/panels/panel_window_controller_cocoa.h',
       'browser/ui/cocoa/panels/panel_window_controller_cocoa.mm',
       'browser/ui/cocoa/passwords/manage_password_item_view_controller.h',

[msw, 2014/09/06 02:15:26]

are these c/b/ui/cocoa/passwords files still in use?

[Garrett Casto, 2014/09/10 00:10:17]

Yes, save passwords bubble.

       'browser/ui/cocoa/passwords/manage_password_item_view_controller.mm',
       'browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.h',
       'browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm',
       'browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.h',
       'browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm',
       'browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.h',
       'browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm',
       'browser/ui/cocoa/passwords/manage_passwords_bubble_content_view_controller.h',
       'browser/ui/cocoa/passwords/manage_passwords_bubble_content_view_controller.mm',
       'browser/ui/cocoa/passwords/manage_passwords_bubble_controller.h',
@@ skipping 169 matching lines @@
       'browser/ui/login/login_prompt.cc',
       'browser/ui/login/login_prompt.h',
       'browser/ui/media_utils.cc',
       'browser/ui/media_utils.h',
       'browser/ui/navigation_correction_tab_observer.cc',
       'browser/ui/navigation_correction_tab_observer.h',
       'browser/ui/metro_pin_tab_helper_win.cc',
       'browser/ui/metro_pin_tab_helper_win.h',
       'browser/ui/omnibox/omnibox_view.cc',
       'browser/ui/omnibox/omnibox_view.h',
       'browser/ui/passwords/manage_passwords_bubble.cc',

[msw, 2014/09/06 02:15:26]

Are these c/b/ui/passwords/* files still in use?

[Garrett Casto, 2014/09/10 00:10:17]

Yes, save passwords bubble.

       'browser/ui/passwords/manage_passwords_bubble.h',
       'browser/ui/passwords/manage_passwords_bubble_model.cc',
       'browser/ui/passwords/manage_passwords_bubble_model.h',
       'browser/ui/passwords/manage_passwords_icon.cc',
       'browser/ui/passwords/manage_passwords_icon.h',
       'browser/ui/passwords/manage_passwords_ui_controller.cc',
       'browser/ui/passwords/manage_passwords_ui_controller.h',
       'browser/ui/passwords/password_manager_presenter.cc',
       'browser/ui/passwords/password_manager_presenter.h',
       'browser/ui/passwords/password_ui_view.h',
@@ skipping 261 matching lines @@
       'browser/ui/webui/mojo_web_ui_controller.h',
       'browser/ui/webui/mojo_web_ui_handler.h',
       'browser/ui/webui/net_export_ui.cc',
       'browser/ui/webui/net_export_ui.h',
       'browser/ui/webui/net_internals/net_internals_ui.cc',
       'browser/ui/webui/net_internals/net_internals_ui.h',
       'browser/ui/webui/omnibox/omnibox_ui.cc',
       'browser/ui/webui/omnibox/omnibox_ui.h',
       'browser/ui/webui/omnibox/omnibox_ui_handler.cc',
       'browser/ui/webui/omnibox/omnibox_ui_handler.h',
       'browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc',

[msw, 2014/09/06 02:15:26]

ditto

[Garrett Casto, 2014/09/10 00:10:17]

Yes, this is chrome://password-manager-internals

       'browser/ui/webui/password_manager_internals/password_manager_internals_ui.h',
       'browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc',
       'browser/ui/webui/performance_monitor/performance_monitor_ui_util.h',
       'browser/ui/webui/predictors/predictors_handler.cc',
       'browser/ui/webui/predictors/predictors_handler.h',
       'browser/ui/webui/predictors/predictors_ui.cc',
       'browser/ui/webui/predictors/predictors_ui.h',
       'browser/ui/webui/profiler_ui.cc',
       'browser/ui/webui/profiler_ui.h',
       'browser/ui/webui/signin_internals_ui.cc',
@@ skipping 627 matching lines @@
       'browser/ui/webui/options/language_options_handler_common.cc',
       'browser/ui/webui/options/language_options_handler_common.h',
       'browser/ui/webui/options/manage_profile_handler.cc',
       'browser/ui/webui/options/manage_profile_handler.h',
       'browser/ui/webui/options/media_devices_selection_handler.cc',
       'browser/ui/webui/options/media_devices_selection_handler.h',
       'browser/ui/webui/options/options_handlers_helper.cc',
       'browser/ui/webui/options/options_handlers_helper.h',
       'browser/ui/webui/options/options_ui.cc',
       'browser/ui/webui/options/options_ui.h',
       'browser/ui/webui/options/password_manager_handler.cc',

[msw, 2014/09/06 02:15:26]

ditto

[Garrett Casto, 2014/09/10 00:10:17]

Yes, this is chrome://passwords

       'browser/ui/webui/options/password_manager_handler.h',
       'browser/ui/webui/options/pepper_flash_content_settings_utils.cc',
       'browser/ui/webui/options/pepper_flash_content_settings_utils.h',
       'browser/ui/webui/options/reset_profile_settings_handler.cc',
       'browser/ui/webui/options/reset_profile_settings_handler.h',
       'browser/ui/webui/options/search_engine_manager_handler.cc',
       'browser/ui/webui/options/search_engine_manager_handler.h',
       'browser/ui/webui/options/startup_pages_handler.cc',
       'browser/ui/webui/options/startup_pages_handler.h',
       'browser/ui/webui/options/supervised_user_create_confirm_handler.cc',
@@ skipping 143 matching lines @@
       'browser/ui/views/autofill/decorated_textfield.cc',
       'browser/ui/views/autofill/decorated_textfield.h',
       'browser/ui/views/autofill/expanding_textfield.cc',
       'browser/ui/views/autofill/expanding_textfield.h',
       'browser/ui/views/autofill/generated_credit_card_bubble_views.cc',
       'browser/ui/views/autofill/generated_credit_card_bubble_views.h',
       'browser/ui/views/autofill/info_bubble.cc',
       'browser/ui/views/autofill/info_bubble.h',
       'browser/ui/views/autofill/new_credit_card_bubble_views.cc',
       'browser/ui/views/autofill/new_credit_card_bubble_views.h',
       'browser/ui/views/autofill/password_generation_popup_view_views.cc',

[msw, 2014/09/06 02:15:26]

ditto

[Garrett Casto, 2014/09/10 00:10:17]

Yes, this is the new generation implementation.

       'browser/ui/views/autofill/password_generation_popup_view_views.h',
       'browser/ui/views/autofill/tooltip_icon.cc',
       'browser/ui/views/autofill/tooltip_icon.h',
       'browser/ui/views/auto_keep_alive.cc',
       'browser/ui/views/auto_keep_alive.h',
       'browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc',
       'browser/ui/views/bookmarks/bookmark_bar_instructions_view.h',
       'browser/ui/views/bookmarks/bookmark_bar_view.cc',
       'browser/ui/views/bookmarks/bookmark_bar_view.h',
       'browser/ui/views/bookmarks/bookmark_bubble_view.cc',
@@ skipping 236 matching lines @@
       'browser/ui/views/panels/panel_frame_view.cc',
       'browser/ui/views/panels/panel_frame_view.h',
       'browser/ui/views/panels/panel_stack_view.cc',
       'browser/ui/views/panels/panel_stack_view.h',
       'browser/ui/views/panels/panel_view.cc',
       'browser/ui/views/panels/panel_view.h',
       'browser/ui/views/panels/taskbar_window_thumbnailer_win.cc',
       'browser/ui/views/panels/taskbar_window_thumbnailer_win.h',
       'browser/ui/views/panels/x11_panel_resizer.cc',
       'browser/ui/views/panels/x11_panel_resizer.h',
-      'browser/ui/views/password_generation_bubble_view.cc',
-      'browser/ui/views/password_generation_bubble_view.h',
       'browser/ui/views/passwords/manage_password_item_view.cc',

[msw, 2014/09/06 02:15:26]

Are these other c/b/ui/views/passwords/* files still in use?

[Garrett Casto, 2014/09/10 00:10:17]

Yes, save passwords bubble.

       'browser/ui/views/passwords/manage_password_item_view.h',
       'browser/ui/views/passwords/manage_passwords_bubble_view.cc',
       'browser/ui/views/passwords/manage_passwords_bubble_view.h',
       'browser/ui/views/passwords/manage_passwords_icon_view.cc',
       'browser/ui/views/passwords/manage_passwords_icon_view.h',
       'browser/ui/views/pdf_password_dialog.cc',
       'browser/ui/views/process_singleton_dialog_linux.cc',
       'browser/ui/views/profiles/avatar_label.cc',
       'browser/ui/views/profiles/avatar_label.h',
       'browser/ui/views/profiles/avatar_menu_bubble_view.cc',
@@ skipping 381 matching lines @@
         'common',
         'common_net',
         'in_memory_url_index_cache_proto',
         '../components/components.gyp:auto_login_parser',
         '../components/components.gyp:dom_distiller_core',
         '../components/components.gyp:dom_distiller_webui',
         '../components/components.gyp:feedback_proto',
         '../components/components.gyp:invalidation',
         '../components/components.gyp:omaha_query_params',
         '../components/components.gyp:onc_component',
         '../components/components.gyp:password_manager_core_browser',

[msw, 2014/09/06 02:15:26]

ditto

[Garrett Casto, 2014/09/10 00:10:17]

Yes.

         '../components/components_resources.gyp:components_resources',
         '../components/components_strings.gyp:components_strings',
         '../content/content.gyp:content_browser',
         '../content/content.gyp:content_common',
         '../crypto/crypto.gyp:crypto',
         '../skia/skia.gyp:skia',
         '../sync/sync.gyp:sync',
         '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation',
         '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation_proto_cpp',
         '../third_party/icu/icu.gyp:icui18n',
@@ skipping 403 matching lines @@
         }],
         ['OS!="android" and OS!="ios"', {
           'dependencies': [
             '../device/bluetooth/bluetooth.gyp:device_bluetooth',
           ],
         }],
       ],
     },
   ],
 }