[SyncFS] Fix unexpected delay on running sync task

[SyncFS] Fix unexpected delay on running sync task

 * Don't count demoted dirty tracker as pending.
 * Notify observer of service state update when the initialization is completed.

BUG=410675
Committed: https://crrev.com/2ee5f5df065a9b2f4a54eaa16d179be0c5a8319f
Cr-Commit-Position: refs/heads/master@{#293474}

[tzik, 2014-09-04 09:41:04]

tzik@chromium.org changed reviewers:
+ peria@chromium.org

[tzik, 2014-09-04 09:41:44]

PTL

[peria, 2014-09-04 09:47:49]

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:501:
void MetadataDatabaseIndexOnDisk::DemoteDirtyTracker(int64 tracker_id) {
You have to update this method, too.

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:528:
void MetadataDatabaseIndexOnDisk::PromoteDemotedDirtyTracker(int64 tracker_id) {
ditto.

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:538:
bool MetadataDatabaseIndexOnDisk::PromoteDemotedDirtyTrackers() {
ditto.

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right):

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/sync_engine.cc:667: void
SyncEngine::OnPushNotificationEnabled(bool enabled) {}
|enabled| seems not to be used?

[tzik, 2014-09-04 10:57:07]

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:501:
void MetadataDatabaseIndexOnDisk::DemoteDirtyTracker(int64 tracker_id) {
On 2014/09/04 09:47:48, peria wrote:
> You have to update this method, too.

Done.

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:528:
void MetadataDatabaseIndexOnDisk::PromoteDemotedDirtyTracker(int64 tracker_id) {
On 2014/09/04 09:47:48, peria wrote:
> ditto.

Done.

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:538:
bool MetadataDatabaseIndexOnDisk::PromoteDemotedDirtyTrackers() {
On 2014/09/04 09:47:48, peria wrote:
> ditto.

Done.

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right):

https://codereview.chromium.org/537883002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/sync_engine.cc:667: void
SyncEngine::OnPushNotificationEnabled(bool enabled) {}
On 2014/09/04 09:47:48, peria wrote:
> |enabled| seems not to be used?

Commented out. Our style guide (and linter) seems to disallow empty parameter
name here.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

[peria, 2014-09-04 16:27:21]

lgtm

[tzik, 2014-09-04 16:30:07]

The CQ bit was checked by tzik@chromium.org

[tzik, 2014-09-04 16:30:12]

The CQ bit was unchecked by tzik@chromium.org

[peria, 2014-09-05 05:07:17]

now you can commit this patch.
please run rebase before submitting.

[tzik, 2014-09-05 05:25:51]

Patchset #4 (id:60001) has been deleted

[tzik, 2014-09-05 05:28:58]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-09-05 05:30:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/537883002/80001

[commit-bot: I haz the power, 2014-09-05 06:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 06:38:07]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tzik, 2014-09-05 07:11:14]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-09-05 07:12:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/537883002/100001

[commit-bot: I haz the power, 2014-09-05 08:19:19]

Committed patchset #5 (id:100001) as aca862ed11e3b590ebc16309e6213d39d9036dc6

[commit-bot: I haz the power, 2014-09-10 03:37:56]

Patchset 5 (id:??) landed as
https://crrev.com/2ee5f5df065a9b2f4a54eaa16d179be0c5a8319f
Cr-Commit-Position: refs/heads/master@{#293474}