chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc - Issue 537883002: [SyncFS] Fix unexpected delay on running sync task

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc

Issue 537883002: [SyncFS] Fix unexpected delay on running sync task (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@peria

Patch Set: fix test expectation Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc ('k') | chrome/browser/sync_file_system/drive_backend/sync_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc b/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc

index bab07cc9902cd8744a746829444156a93e0ab098..8bd1ae9724e0a27a3ac9d04da0a854f971fc2e68 100644

--- a/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc

+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc

@@ -591,7 +591,7 @@ TEST_F(MetadataDatabaseIndexOnDiskTest, DirtyTrackersTest) {

index()->DemoteDirtyTracker(kPlaceholderTrackerID);

WriteToDB();

EXPECT_TRUE(index()->HasDemotedDirtyTracker());

- EXPECT_EQ(1U, index()->CountDirtyTracker());

+ EXPECT_EQ(0U, index()->CountDirtyTracker());

const int64 tracker_id = 13;

scoped_ptr<FileTracker> app_root_tracker(new FileTracker);

@@ -604,7 +604,7 @@ TEST_F(MetadataDatabaseIndexOnDiskTest, DirtyTrackersTest) {

app_root_tracker.get());

index()->StoreFileTracker(tracker.Pass());

WriteToDB();

- EXPECT_EQ(2U, index()->CountDirtyTracker());

+ EXPECT_EQ(1U, index()->CountDirtyTracker());

EXPECT_EQ(tracker_id, index()->PickDirtyTracker());

// Testing UpdateDirtyTrackerIndexes

@@ -614,7 +614,7 @@ TEST_F(MetadataDatabaseIndexOnDiskTest, DirtyTrackersTest) {

tracker->set_dirty(false);

index()->StoreFileTracker(tracker.Pass());

WriteToDB();

- EXPECT_EQ(1U, index()->CountDirtyTracker());

+ EXPECT_EQ(0U, index()->CountDirtyTracker());

EXPECT_EQ(kInvalidTrackerID, index()->PickDirtyTracker());

tracker = test_util::CreatePlaceholderTracker("placeholder",

@@ -622,13 +622,13 @@ TEST_F(MetadataDatabaseIndexOnDiskTest, DirtyTrackersTest) {

app_root_tracker.get());

index()->StoreFileTracker(tracker.Pass());

WriteToDB();

- EXPECT_EQ(2U, index()->CountDirtyTracker());

+ EXPECT_EQ(1U, index()->CountDirtyTracker());

EXPECT_EQ(tracker_id, index()->PickDirtyTracker());

// Testing RemoveFromDirtyTrackerIndexes

index()->RemoveFileTracker(tracker_id);

WriteToDB();

- EXPECT_EQ(1U, index()->CountDirtyTracker());

+ EXPECT_EQ(0U, index()->CountDirtyTracker());

EXPECT_EQ(kInvalidTrackerID, index()->PickDirtyTracker());

// Demoted trackers