Issue 537833002: Make logger use new sampling API for ticks and code events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 537833002: Make logger use new sampling API for ticks and code events.

Created:
6 years, 3 months ago by gholap

Modified:
6 years ago

Reviewers:
fmeawad

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Make logger use new sampling API for ticks and code events. Based off: https://codereview.chromium.org/422593003/

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -108 lines)			Patch
	M	src/log.h	View		5 chunks	+23 lines, -3 lines	0 comments	Download
	M	src/log.cc	View		13 chunks	+114 lines, -105 lines	0 comments	Download

Messages

Total messages: 4 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

gholap

6 years, 3 months ago (2014-09-04 06:48:49 UTC) #2

Now the logger makes use of the public sampling API for logging samples and
makes use of the JitCodeEvents for logging code-create code-move and code-delete
events.

What do you think?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages